Add "all activity" breadcrumb to D&D tables #5694
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
refs/pull/5694/merge
|
| Run status |
|
| Run duration | 00m 46s |
| Commit |
|
| Committer | jpople |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
5
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
There was a problem hiding this comment.
@jpople The first 2 links both point to the same place now, which seems odd. Is that expected?
| onPathClick(urnParts.slice(0, index + 1).join(".")); | ||
| } | ||
| : undefined, | ||
| href: isLast ? undefined : "", |
There was a problem hiding this comment.
We don't actually use the href for navigation but its presence determines whether the item has a hover state.
There was a problem hiding this comment.
In that case I would suggest we update NextBreadcrumb to look for onclick without href and use a button element in that instance instead of the NextLink element, especially for accessibility concerns.
| size="small" | ||
| icon={modifiedItem.icon} | ||
| onClick={modifiedItem.onClick} | ||
| className="ant-breadcrumb-link -mt-px px-1 text-inherit" |
There was a problem hiding this comment.
@gilluminate Updated NextBreadcrumb as you suggested.
This top margin is ugly, but was the closest I was able to get to centering the buttons vertically so the breadcrumb items are aligned-- Ant doesn't expose much of its item rendering and they don't have classes to style with SCSS either.
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 48s |
| Commit |
|
| Committer | jpople |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
5
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Closes HJ-389
Description Of Changes
Adds an "all activity" breadcrumb linking to the respective root page to both detection and discovery result tables.
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works