Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "all activity" breadcrumb to D&D tables #5694

Merged
merged 9 commits into from
Jan 29, 2025
Merged

Add "all activity" breadcrumb to D&D tables #5694

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
edfb99f
add 'all activity' breadcrumb
jpople Jan 20, 2025
ecaa5a8
update changelog
jpople Jan 20, 2025
0f7fedf
breadcrumb fix
jpople Jan 22, 2025
60f163f
breadcrumb update
jpople Jan 29, 2025
b1f448c
Merge branch 'main' into jpople/hj-389/dnd-all-activity-breadcrumb
jpople Jan 29, 2025
a928cc1
Merge branch 'main' into jpople/hj-389/dnd-all-activity-breadcrumb
jpople Jan 29, 2025
cad83a3
Merge branch 'main' into jpople/hj-389/dnd-all-activity-breadcrumb
jpople Jan 29, 2025
2a02b3b
Merge branch 'main' into jpople/hj-389/dnd-all-activity-breadcrumb
jpople Jan 29, 2025
e0d5ed5
Merge branch 'main' into jpople/hj-389/dnd-all-activity-breadcrumb
jpople Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ Changes can also be flagged with a GitHub label for tracking purposes. The URL o

### Changed
- Updated UI colors to new brand. Update logo, homepage cards. [#5668](https://github.com/ethyca/fides/pull/5668)
- Added "All activity" root breadcrumb to D&D results tables [#5694](https://github.com/ethyca/fides/pull/5694)

### Developer Experience
- Migrated radio buttons and groups to Ant Design [#5681](https://github.com/ethyca/fides/pull/5681)
Expand Down
4 changes: 4 additions & 0 deletions clients/admin-ui/src/features/data-discovery-and-detection/DiscoveryMonitorBreadcrumbs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ const DiscoveryMonitorBreadcrumbs = ({
}

if (resourceUrn) {
breadcrumbItems.push({
title: "All activity",
href: parentLink,
});
const urnParts = resourceUrn.split(".");
urnParts.forEach((urnPart, index) => {
// don't render anything at the monitor level because there's no view for it
Expand Down
Loading