Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ubuntu 18.04 workflow #14

Merged
merged 5 commits into from
May 5, 2023
Merged

Remove ubuntu 18.04 workflow #14

merged 5 commits into from
May 5, 2023

Conversation

4c3y
Copy link
Member

@4c3y 4c3y commented May 2, 2023

  • Removed ubuntu 18.04 workflow
  • Added ubuntu 22.04 workflow

@4c3y
Copy link
Member Author

4c3y commented May 2, 2023

Removed CI for Ubuntu 22.04 with ros noetic because there is a compatibility issue in rosconsole between different versions of liblog4cxx: ros/rosconsole#58

@4c3y 4c3y changed the title Removed ubuntu 18.04 workflow and added ubuntu 22.04 Removed ubuntu 18.04 workflow May 2, 2023
@4c3y 4c3y changed the title Removed ubuntu 18.04 workflow Remove ubuntu 18.04 workflow May 2, 2023
@4c3y 4c3y marked this pull request as ready for review May 2, 2023 09:54
@4c3y 4c3y requested a review from rikba May 2, 2023 09:54
@rikba
Copy link

rikba commented May 3, 2023

Removed CI for Ubuntu 22.04 with ros noetic because there is a compatibility issue in rosconsole between different versions of liblog4cxx: ros/rosconsole#58

You mean Ubuntu 18.04 with ros melodic?? Otherwise LGTM

@4c3y
Copy link
Member Author

4c3y commented May 5, 2023

Removed CI for Ubuntu 22.04 with ros noetic because there is a compatibility issue in rosconsole between different versions of liblog4cxx: ros/rosconsole#58

You mean Ubuntu 18.04 with ros melodic?? Otherwise LGTM

I indeed tried to add an Ubuntu 22.04 workflow, but decided to remove it due to the complexity of installing ros noetic on ubuntu 22.04.

@4c3y 4c3y merged commit 9371f4b into master May 5, 2023
@4c3y 4c3y deleted the fix/ci branch May 5, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants