Compatibility fix for liblog4cxx v0.11-0.13 #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[`log4cxx` uses `std::shared_ptr`](https://issues.apache.org/jira/browse/LOGCXX-486) since [version `0.12`](https://logging.apache.org/log4cxx/latest_stable/changelog.html) Unfortunately Ubuntu 22.04 ships with [`0.12`](https://packages.ubuntu.com/jammy/liblog4cxx12), which means that rosconsole with the `log4cxx` backend wouldn't compile. This is also a problem on other distros such as Arch or Gentoo. I have carefully applied explicit construction/conversion and `&*` instead of `.get()` to make the code compile with both versions of `log4cxx`.
- Partially implements changes suggested both in ros#54 and orphaned commit e3753ee - Tested on liblog4cxx v0.12 and 0.13 - Sets up pointer-level compatibility with both new and old log4cxx versions - Adds a workaround for API breaking changes in liblog4cxx - Testing needed Signed-off-by: Andrey Vukolov <[email protected]>
Signed-off-by: Andrey Vukolov <[email protected]>
TarikViehmann
added a commit
to TarikViehmann/rosfed
that referenced
this pull request
Jan 2, 2023
Fedora 37 ships with log4cxx 0.13. This causes issues in ros-rosconsole, which are solved by ros/rosconsole#58, which is supplied as patch here. Also, all packages that utilize log4cxx need to be build with c++17 due to internal usage of std::shared_mutex.
|
I've validated this patch with GCC 12 / log4cxx 1.1.0 on NixOS 23.05. Looks good to me. 🚢 |
|
This fixes my failing build on Ubuntu 23.10 |
|
Just confirming this also allows log4cxx versions 0.13 and 1.1.0 on Fedora to work. |
|
This fixes my failing build on Raspberry Pi OS(Debian 12 bookworm based). Thanks. |
|
Is anyone hitting runtime issues with this patch? I'm seeing nodes crash in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
log4cxx0.11and0.12#54 and orphaned commit e3753eelog4cxxversionsliblog4cxxI would be very much appreciated if someone would test this code also on
liblog4cxxversion 0.11 to avoid wrong API calls.