Developers may include debug messages in their application logs (#1)

* Developers may include debug messages in their application logs

There were some breaking changes with how the griddler gem was packaged.
This caused rake to fail until we downloaded the photos and updated the spec helper.

* Use Ruby 2.0 compliant syntax for defining protected methods

lib/griddler/mandrill.rb

@@ -1,5 +1,6 @@
 require 'griddler'
 require 'griddler/mandrill/version'
 require 'griddler/mandrill/adapter'
+require 'griddler/mandrill/logging'
 
-Griddler.adapter_registry.register(:mandrill, Griddler::Mandrill::Adapter)
+Griddler.adapter_registry.register(:mandrill, Griddler::Mandrill::Adapter)

lib/griddler/mandrill/adapter.rb

@@ -12,6 +12,7 @@ def self.normalize_params(params)
       end
 
       def normalize_params
+        logger.debug(message: "entered #normalize_params", events: events)
         events.select do |event|
           event[:spf].present? && (event[:spf][:result] == 'pass' || event[:spf][:result] == 'neutral')
         end.map do |event|
@@ -32,6 +33,12 @@ def normalize_params
         end
       end
 
+      protected
+
+      def logger
+        Logging.logger
+      end
+
       private
 
       attr_reader :params

lib/griddler/mandrill/logging.rb

@@ -0,0 +1,28 @@
+module Griddler
+  module Mandrill
+    module Logging
+      # The default logger discards all message; as we do not want
+      # to start clogging up existing users logs.
+      def self.logger
+        @logger ||= NullLogger.new(STDOUT)
+      end
+
+      # Set your application's logger
+      # @example In a Rails initializer:
+      #    Griddler::Mandrill::Logging.logger = Rails.logger
+      # @example In Rails while logging a different level than the default logger
+      #    Griddler::Mandrill::Logging.logger = ActiveSupport::Logger.new(Rails.logger, level: :debug)
+      def self.logger=(logger)
+        @logger = logger
+      end
+
+      # A logger which discards messages
+      class NullLogger < Logger
+        # Overload the Logger#add method as this is where the #info/#warn/#error methods
+        # send their messags to the logging subsystem.
+        def add(*_arguments)
+        end
+      end
+    end
+  end
+end

spec/spec_helper.rb

@@ -1,3 +1,4 @@
+require 'griddler'
 require 'griddler/testing'
 require 'griddler/mandrill'
 require 'action_dispatch'
@@ -10,6 +11,13 @@
   config.include Griddler::Testing
 end
 
+
+class Griddler::Testing::UploadedImage
+  def fixture_file
+    cwd = File.expand_path File.dirname(__FILE__)
+    File.new(File.join(cwd, 'fixtures', @name))
+  end
+end
 RSpec::Matchers.define :be_normalized_to do |expected|
   failure_message do |actual|
     message = ""