refactor(core): setup workspaces #1012
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It detects the packageManager running the command to install the dependencies.
It adds the following dependencies: `@asyncapi/parser` and `prismjs`
It updates the Dockerfile to run with pnpm to ensure compatibility
Updated the dependency check logic to verify the presence of the `node_modules` directory instead of relying solely on `require.resolve` for `astro`. This ensures more robust detection of installed dependencies.
|
- Remove `test-bin.yml` workflow that utilized `Docker`. - Add a job in `verify-build.yml` to replace the functionality, running with `pnpm` directly.
carlosallexandre
force-pushed
the
refactor/setup-workspaces
branch
from
45296e6 to
3f561a0
Compare
carlosallexandre
force-pushed
the
refactor/setup-workspaces
branch
from
06b55e9 to
c903ccd
Compare
|
shall we close this now @carlosallexandre ? Few merge conflicts :O |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Same as #987.
Note:
node_modulesin development of the package, turns the installation required always because of the monorepo structure.