Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: SourceLink #501

Closed
wants to merge 1 commit into from
Closed

WIP: SourceLink #501

wants to merge 1 commit into from

Conversation

rasmus
Copy link
Member

@rasmus rasmus commented Jun 28, 2018

Fixes #459

@codecov
Copy link

codecov bot commented Jun 28, 2018

Codecov Report

Merging #501 into develop will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #501      +/-   ##
===========================================
- Coverage    75.99%   75.96%   -0.03%     
===========================================
  Files          265      265              
  Lines         6714     6714              
  Branches       565      565              
===========================================
- Hits          5102     5100       -2     
+ Misses        1369     1364       -5     
- Partials       243      250       +7
Impacted Files Coverage Δ
...ce/EventFlow/Sagas/AggregateSagas/AggregateSaga.cs 93.33% <0%> (-6.67%) ⬇️
...EventFlow/Configuration/Bootstraps/Bootstrapper.cs 96.29% <0%> (-3.71%) ⬇️
...w.MsSql/RetryStrategies/MsSqlErrorRetryStrategy.cs 48.27% <0%> (-3.45%) ⬇️
...ventFlow/Subscribers/DispatchToEventSubscribers.cs 95.38% <0%> (-3.08%) ⬇️
Source/EventFlow/Sagas/DispatchToSagas.cs 97.26% <0%> (-1.37%) ⬇️
...entFlow/EventStores/Files/FilesEventPersistence.cs 77.44% <0%> (+1.5%) ⬆️
Source/EventFlow/Logs/Log.cs 35.08% <0%> (+3.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92e05a7...15c5f5a. Read the comment docs.

@DavidRouyer
Copy link
Contributor

Do you need help on this one?

@rasmus
Copy link
Member Author

rasmus commented Mar 19, 2019

@DavidRouyer Definitely. Start from scratch or build on this, whatever suites your style. The hard part for me at least, we how to verify that the data is actually added to the assembly, i.e., writing a test.

@rasmus
Copy link
Member Author

rasmus commented Apr 10, 2019

Fixed by #626

@rasmus rasmus closed this Apr 10, 2019
@rasmus rasmus deleted the sourcelink branch April 10, 2019 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants