Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship PDB files with Nuget package #617

Closed
RTodorov opened this issue Mar 25, 2019 · 15 comments
Closed

Ship PDB files with Nuget package #617

RTodorov opened this issue Mar 25, 2019 · 15 comments

Comments

@RTodorov
Copy link

Would be nice to have the PDB files shipped with the nuget package to help with debugging.

For reference: aspnet/Universe#131 (comment)

@DavidRouyer
Copy link
Contributor

See #501, I'll try to work on it this week

@RTodorov
Copy link
Author

Nice, SourceLink would also solve the problem, thanks for the good work!

@wgtmpeters
Copy link
Contributor

Is there anything planned for this? It seems like with the latest version I am not able to load the symbols in the module view during debugging.
And that is needed to be able to use sourcelink to step into the code right?

@rasmus
Copy link
Member

rasmus commented May 15, 2019

Source link is added #626

@DavidRouyer
Copy link
Contributor

@rasmus Have you published the symbol package on NuGet?

@rasmus
Copy link
Member

rasmus commented May 15, 2019

@DavidRouyer yes, the changes went out in release v0.70.3824 that went on NuGet org the 2019-04-11

@rasmus
Copy link
Member

rasmus commented May 15, 2019

But we could add the PDB files as well

@rasmus
Copy link
Member

rasmus commented May 15, 2019

Trying it out in #638

@DavidRouyer
Copy link
Contributor

@rasmus You merged the changes but you have to publish the symbols package (.snupkg) along with the .nupkg.
Once it's done, you should see this:
Capture

On your package page https://www.nuget.org/packages/EventFlow

@rasmus
Copy link
Member

rasmus commented May 15, 2019

Yes, the issue are the AppVeyor built-in support for uploading NuGet packages that EventFlow uses:
appveyor/ci#2753

The packages aren't picked up. I'll see if can upload them manually after the release completes until it gets fixed. Adding the files to the GitHub release here #639.

But, I hope they fix it as I dislike downloading release packages to my personal desktop. If they don't it will need to be built manually.

@rasmus
Copy link
Member

rasmus commented May 15, 2019

May have found a simple workaround

@rasmus
Copy link
Member

rasmus commented May 26, 2019

The source link integration is broken. I opened #644 to reflect it. Closing this issue as the original idea is implemented (although broken).

@rasmus rasmus closed this as completed May 26, 2019
@rasmus
Copy link
Member

rasmus commented May 26, 2019

The PDB files will be in the normal package and in the snupkg as well after #645 is done

@rasmus
Copy link
Member

rasmus commented May 28, 2019

Released in v0.72.3914 along with corrected source link support. Remember to disable "just my code"

@rasmus
Copy link
Member

rasmus commented May 28, 2019

image

snupkg files are also released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants