DEVPROD-13969 Remove s3.push and s3.pull #8637
Conversation
| @@ -70,9 +70,6 @@ type attachResults struct { | |||
| func attachResultsFactory() Command { return &attachResults{} } | |||
| func (c *attachResults) Name() string { return evergreen.AttachResultsCommandName } | |||
|
|
|||
| // ParseParams decodes the S3 push command parameters that are | |||
There was a problem hiding this comment.
could we keep this comment and just reword for attach results?
There was a problem hiding this comment.
I was cleaning up the comments since only these commands document this function. I'm okay with documenting it but do you want me to add it to all the other commands?
There was a problem hiding this comment.
nah either works, i feel like comments are always helpful so removing them doesn't seem necessary, but you don't need to go do a ton of work here; if you'd rather just keep it removed that's fine too
| @@ -100,7 +100,6 @@ type s3Loc struct { | |||
| func s3CopyFactory() Command { return &s3copy{} } | |||
| func (c *s3copy) Name() string { return "s3Copy.copy" } | |||
|
|
|||
| // ParseParams decodes the S3 push command parameters | |||
| @@ -35,10 +35,6 @@ | |||
| "admins": ["annie.black"], | |||
There was a problem hiding this comment.
didn't know i was in the codebase this much LOL
validator/project_validator.go
Outdated
| var longErrorValidators = []longValidator{ | ||
| validateTaskSyncCommands, | ||
| } | ||
| var longErrorValidators = []longValidator{} |
There was a problem hiding this comment.
We can just get rid of this and the --long flag, since there's nothing in here! (Can do in another PR but might be good to do as a quick-win in the nearterm just to keep things clean)
There was a problem hiding this comment.
Sure, I wasn't sure if we regularly cycle validators in here. I'll remove it in this PR!
There was a problem hiding this comment.
I've removed the long flag from validate command as well. The latest commit has the changes for the long flag/validator
ZackarySantana
changed the title
| @@ -1659,7 +1659,7 @@ func (h *createGitHubDynamicAccessToken) Run(ctx context.Context) gimlet.Respond | |||
| }) | |||
| } | |||
|
|
|||
| // DELETE /rest/v2/task/{task_id}/github_dynamic_access_tokens | |||
| // DELETE /rest/v2/task/{task_id}/github_dynamic_access_token | |||
DEVPROD-13969
Description
This removes the s3.push and s3.pull commands.
Testing
Existing unit tests.
Spruce PR
#574 has to be merged first.