Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVPROD-13969: Remove task sync project settings [minor] #574

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

ZackarySantana
Copy link
Contributor

DEVPROD-13969

Description

This removes the task sync project settings and the checkbox for spawnhosts.

I'm not that familiar with the UI codebase so please feel free to nitpick or anything!

Screenshots

New:
Screenshot 2025-01-15 at 1 39 06 PM
Old:
Screenshot 2025-01-15 at 1 39 20 PM

Testing

Saved settings and it worked as normal.

Evergreen PR

#8637 has to be merged after this change.

@ZackarySantana
Copy link
Contributor Author

ZackarySantana commented Jan 15, 2025

I got a failing codegen task because my codegen was based on the Evergreen PR. Should I make a 2nd PR after the Evergreen PR is merged that is redoing codegen? I redid the codegen without the changes for now

@ZackarySantana
Copy link
Contributor Author

The type check failed but I reran it and it passed (task).

Copy link
Contributor

@minnakt minnakt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! Don't worry about updating codegen after merging your backend PR, someone else will see it fail on their PR and will update it naturally.

Slightly unsure about the major label (but I also think it's subjective). For example I'm thinking about how the new waterfall release will probably be major, and I'm not sure if this is on the same scale.

@sophstad
Copy link
Contributor

Slightly unsure about the major label (but I also think it's subjective). For example I'm thinking about how the new waterfall release will probably be major, and I'm not sure if this is on the same scale.

+1, I'd go with [minor]

@ZackarySantana ZackarySantana changed the title DEVPROD-13969: Remove task sync project settings [major] DEVPROD-13969: Remove task sync project settings [minor] Jan 16, 2025
@ZackarySantana
Copy link
Contributor Author

Switched to minor!

@ZackarySantana ZackarySantana merged commit 45c462e into evergreen-ci:main Jan 16, 2025
3 checks passed
@ZackarySantana ZackarySantana deleted the DEVPROD-13969 branch January 16, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants