Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Improve Chinese (Taiwan) and Chinese (China) translation #585

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

whyjz
Copy link
Contributor

@whyjz whyjz commented Jul 12, 2022

I edited the translations to make them look more natural and better match the context.

PS. I am a native Chinese (Taiwan) speaker and have a decent understanding of Chinese (China).

@welcome
Copy link

welcome bot commented Jul 12, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

Copy link
Member

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so helpful, thanks very much @whyjz - it is really hard to keep translations up-to-date and accurate 🙏

@choldgraf choldgraf changed the title Improve Chinese (Taiwan) and Chinese (China) translation ENH: Improve Chinese (Taiwan) and Chinese (China) translation Jul 19, 2022
@choldgraf choldgraf merged commit 29f5368 into executablebooks:master Jul 19, 2022
@welcome
Copy link

welcome bot commented Jul 19, 2022

Congrats on your first merged pull request in this project! 🎉
congrats

Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants