-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Use the src
folder as the Metro target
#29702
Conversation
The Pull Request introduced fingerprint changes against the base commit: d8114cd Fingerprint diff[
{
"type": "dir",
"filePath": "../../node_modules/expo",
"reasons": [
"bareRncliAutolinking"
],
"hash": "e39701ffc215df207db804dc1a44fc5c6363b6e6"
},
{
"type": "dir",
"filePath": "../../packages/expo",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid",
"expoConfigPlugins",
"expoConfigPlugins"
],
"hash": "d7e91c582bf1df8ff9e7d22cba3d0bb190a47967"
},
{
"type": "dir",
"filePath": "../../packages/expo-modules-core",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid"
],
"hash": "fbb4351e75bb473a2d79245b7a2a3293acc59290"
}
] Generated by PR labeler 🤖 |
cd69b49
to
115eab7
Compare
926444e
to
a165467
Compare
Co-authored-by: Expo Bot <[email protected]>
a165467
to
31cb425
Compare
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇
|
# Why - I noticed in my tree-shaking prototype that the side effects weren't being recognized. Updating to account for #29702 --------- Co-authored-by: Expo Bot <[email protected]>
Why
Following up on #29244
How
Followed #29244, but for
expo
andexpo-modules-core
packages.build
withsrc
in the entry pointemitDeclarationOnly
totrue
in TS configs.js
and.js.map
files from thebuild
folderjest-expo
,@expo/metro-config
and AppEntryTest Plan
Tested in bare-expo on iOS and web and confirmed that:
src
automatically reloads the app without runningyarn build