-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[typescript] Create tsconfig.next.json #33721
base: main
Are you sure you want to change the base?
Conversation
Subscribed to pull request
Generated by CodeMention |
a71b824
to
c6d3d79
Compare
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇
|
@@ -33,6 +33,7 @@ | |||
"@expo/npm-proofread": "^1.0.1", | |||
"@testing-library/react-native": "^12.5.2", | |||
"@tsconfig/node18": "^18.2.2", | |||
"@tsconfig/react-native": "^3.0.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to confirm, is it intended to use the community-based @tsconfig/react-native
instead of the @react-native/typescript-config
from the React Native monorepo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use the official one, this was a mistake
What are the reasons that these libraries choose to ship their code precompiled, even though Metro prefers non-precompiled packages? In contrast, there is a trend in the Expo repository this year towards shipping TypeScript source files, as seen in the following pull requests: #33781, #30665, #29702, #29244. |
@reichhartd We should ship both Metro supports conditional exports with a
|
Why
React Contributors discord request
This the first step of many upgrade Expo's SDK to the latest TypeScript and align our
tsconfig.json
with the recommended settings.@tsconfig/react-native
@tsconfig/react-native
enablesstrict: true
so the partial strict options were removednoUnusedLocals
inlineSource
, I don't believe this is needed with the new debugger.types
override. Where we using"jest-require"
? Modules that do not run on device should override this settinglib
override. Modules that do not run on device (or in multiple environments) should override this settingbuild
folder output). Modules will need to disable this if they do not perform a build step, or have alternative build tooling (cli).react-native-builder-bob
/react-native-reanimated
/react-native-navigation
all ship precompiled. https://bsky.app/profile/satya164.page/post/3ldf4egm2jk2qAll-in-all, when a module switches to this
tsconfig
we will need tobuild
dir beingThis
tsconfig
does not yet include the changes tomodule
. I suspect the changes tostrict
are enough work for now. Thereact-native
repro just switched toesnext
this week.