Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to support breaking change from 08f8141 #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

EricRabil
Copy link

salesforce/tough-cookie@08f8141 broke this library, and on newer versions the callback parameter became the allowSpecialUseDomain. This PR fixes compatibility with newer versions.

@EricRabil EricRabil changed the title Updated to support breaking change from 08f81419c5beaaa8d076c9eb062f628f258525ae Updated to support breaking change from 08f8141 Jan 27, 2021
@bryzaguy
Copy link

You need to pass allowSpecialUseDomain to ToughCookie.permuteDomain(domain, allowSpecialUseDomain) on line 35. However, I don't know what point there is since this repo does not appear to be maintained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants