feat: Implement add a “align” parameter for ui.inline #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into verticalAlignment
… into verticalAlignment
This change avoid having both “alignment” and “align” parameters in the same function. The new names are consistent with the terminology used in CSS and other H2O Wave functions such as ui.zone and ui.buttons.
monal20
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
alignparameter toui.inlinethat allows users to specify the vertical alignment of the items.The API is updated as follows:
interface Inline { /** The components laid out inline. */ items: Component[] /** Specifies how to lay out the individual components. Defaults to 'start'. */ justify?: 'start' | 'end' | 'center' | 'between' | 'around' + /** Specifies how the individual components are aligned on the vertical axis. Defaults to 'center'. */ + align?: 'start' | 'end' | 'center' | 'baseline' | 'stretch' /** Whether to display the components inset from the parent form, with a contrasting background. */ inset?: B }The PR also adds a new example showing how values for the
justifyandalignparameters ofui.inlinework:ui_inline_demo.mov
I also renamed the
alignmentparameter of the internal functionXComponentstojustify(more details here: 08d6813).Closes 1535.