Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow vertical alignment for ui.inline #1535

Closed
mturoci opened this issue Jul 12, 2022 · 7 comments · Fixed by #1737
Closed

Allow vertical alignment for ui.inline #1535

mturoci opened this issue Jul 12, 2022 · 7 comments · Fixed by #1737
Labels
feature Feature request good first issue Contributions welcome! ui Related to UI

Comments

@mturoci
Copy link
Collaborator

mturoci commented Jul 12, 2022 •
edited
Loading

via @azim-b

Add align attr to ui.inline to allow for vertical alignment. Currently, we center everything by default, which does not suit every case, e.g. displaying 2 choice groups side by side with different choice counts:

image

Implementation notes

  • Add a new align prop to Inline interface with all the possible values that flexbox offers for vertical alignment.
  • Implement the necessary functionality.
  • Add a python example demonstrating the behavior.
@mturoci mturoci added ui Related to UI feature Feature request labels Jul 12, 2022
@mturoci mturoci added the good first issue Contributions welcome! label Sep 12, 2022
@NevilleMthw
Copy link

NevilleMthw commented Sep 26, 2022 •
edited
Loading

Is anyone doing this issue? If not, I could work on it.

@mturoci
Copy link
Collaborator Author

mturoci commented Sep 26, 2022

You can take it @NevilleMthw!

@NevilleMthw
Copy link

Hi @mturoci, is there a separate inline.tsx file to work with or would the changes be in another file?

@mturoci
Copy link
Collaborator Author

mturoci commented Sep 27, 2022

The changes need to be done in form.tsx. Here is the interface and the component. For quicker answers you might also want to join our Discord.

@NevilleMthw NevilleMthw mentioned this issue Sep 28, 2022
Closed
@mturoci
Copy link
Collaborator Author

mturoci commented Oct 13, 2022

This issue is up for grabs again.

This was referenced Nov 30, 2022
Closed
Closed
Open
@Nicolapps
Copy link
Contributor

I’m working with @sherrychen2, @monal20, and @kitty3190 on a PR for this issue (and also #1645, #495, and #372) as part of a Software Engineering class assignment.

@jding712
Copy link

Hi, my team would like to work on this issue if it is still available.

Nicolapps added a commit to Nicolapps/wave that referenced this issue Dec 3, 2022
@Nicolapps
feat: Implement ui.inline’s align parameter h2oai#1535
df0d421
This was referenced Dec 6, 2022
Merged
Merged
Nicolapps added a commit to Nicolapps/wave that referenced this issue Dec 6, 2022
@Nicolapps
docs: Add new example to tour.conf h2oai#1535
d51f523
Nicolapps added a commit to Nicolapps/wave that referenced this issue Dec 6, 2022
@Nicolapps
docs: Add thumbnail image for new example h2oai#1535
b4054e7
Nicolapps added a commit to Nicolapps/wave that referenced this issue Dec 8, 2022
@Nicolapps
docs: fix style of the inline.py example h2oai#1535
40e2e20
Nicolapps added a commit to Nicolapps/wave that referenced this issue Dec 8, 2022
@Nicolapps
docs: add code examples for ui.line params h2oai#1535
bd14288
Nicolapps added a commit to Nicolapps/wave that referenced this issue Dec 9, 2022
@Nicolapps
feat: remove 'stretch' for ui.inline h2oai#1535
520fd37
mturoci pushed a commit that referenced this issue Dec 12, 2022
@Nicolapps
feat: Add “align” parameter for ui.inline #1535 (#1737)
3773c0f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Feature request good first issue Contributions welcome! ui Related to UI
Projects
None yet
Milestone
No milestone
4 participants
@Nicolapps @NevilleMthw @mturoci @jding712