Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component | Chord Diagram | Fixes, enhancements, and refactoring #318

Merged
merged 3 commits into from
Dec 19, 2023
Merged

Component | Chord Diagram | Fixes, enhancements, and refactoring #318

merged 3 commits into from
Dec 19, 2023

Conversation

reb-dev
Copy link
Collaborator

@reb-dev reb-dev commented Dec 18, 2023 •
edited
Loading

Additions

  • Background selector for events
  • CSS variable for node label font size

Refactoring

  • Extracted layout logic to new module
  • Replaced d3.nest (deprecated) with d3.group for hierarchal data generation

Fixes

  • Overlapping "empty" nodes (nodes without any ingoing or outgoing links)
  • Pad angle inconsistent behavior
  • Empty nodes not highlighting on hover
  • Changing config after initial render doesn't have any effect (except for radiusScaleExponent)

Closes: unovis/issues-only#13
Closes: unovis/issues-only#19
Closes: unovis/issues-only#20
Closes: unovis/issues-only#21

@reb-dev reb-dev merged commit 0c1eb48 into main Dec 19, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@reb-dev