Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Unify python dependencies into requirements.in #701

Merged
merged 16 commits into from
Nov 27, 2020

Conversation

rafiu007
Copy link
Member

@rafiu007 rafiu007 commented Nov 17, 2020

This is WIP PR which takes care of dependency unification for the api server.

Checklist ::

  • Move any test specific packages from requirements.in to tests/requirements.in
  • Move any direct pip installations from Dockerfile.* to requirements.in
  • Move any direct pip installations from tests/*.sh to tests/requirements.in
  • Relative versioning in requirements.in & tests/requirements.in (no version pinning unless otherwise needed)
  • Generate requirements.txt (not required) and tests/requirements.txt
  • (Not Applicable)Update setup.py to use requirement.in
  • Cleanup unused dependencies from requirements.in and tests/requirements.in (using pip install pipreqs)

requirements.in Show resolved Hide resolved
tests/requirements.in Show resolved Hide resolved
@rafiu007 rafiu007 changed the title Test Dependency unification Nov 17, 2020
requirements.in Outdated Show resolved Hide resolved
requirements.in Outdated Show resolved Hide resolved
@arajkumar
Copy link
Member

@rafiu007 Could you please follow the template/checklist described in fabric8-analytics/fabric8-analytics-utils#57 (comment)?

setup.py Outdated Show resolved Hide resolved
tests/requirements.txt Show resolved Hide resolved
@arajkumar arajkumar changed the title Dependency unification chore: Unify python dependencies into requirements.in Nov 24, 2020
Copy link
Contributor

@dgpatelgit dgpatelgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added check-list template to PR description, @rafiu007 can you check and update the list as per code changes?

requirements.in Outdated Show resolved Hide resolved
requirements.in Outdated Show resolved Hide resolved
tests/requirements.txt Show resolved Hide resolved
requirements.in Outdated Show resolved Hide resolved
requirements.in Outdated Show resolved Hide resolved
tests/requirements.in Outdated Show resolved Hide resolved
Copy link
Member

@arajkumar arajkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also Dockerfile.tests should be modified to install pip packages from tests/requirements.txt

@arajkumar
Copy link
Member

Just started reviewing :)

Copy link
Member

@arajkumar arajkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rafiu007 Please wait for one more approval.

Copy link
Contributor

@dgpatelgit dgpatelgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@deepak1725 deepak1725 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arajkumar arajkumar merged commit 7378faa into fabric8-analytics:master Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants