Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APPAI-1418] Resolve vulnerabilities for dependencies in Utils component #57

Merged
merged 6 commits into from
Jul 28, 2020

Conversation

dgpatelgit
Copy link
Contributor

@dgpatelgit dgpatelgit commented Jul 21, 2020

Jira Issue :: https://issues.redhat.com/browse/APPAI-1418

Checklist ::

  • Move any test specific packages from requirements.in to tests/requirements.in
  • (Not Applicable) Move any direct pip installations from Dockerfile.* to requirements.in
  • Move any direct pip installations from tests/*.sh to tests/requirements.in
  • Relative versioning in requirements.in & tests/requirements.in (no version pinning unless otherwise needed)
  • Generate requirements.txt (not required) and tests/requirements.txt
  • Update setup.py to use requirement.in

@centos-ci
Copy link
Collaborator

@dgpatelgit Your image is available in the registry: docker pull MISSING_REGISTRY_NAME/MISSING_IMAGE_NAME:SNAPSHOT-PR-57

@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2020

Codecov Report

Merging #57 into master will increase coverage by 0.32%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #57      +/-   ##
===========================================
+ Coverage   99.67%   100.00%   +0.32%     
===========================================
  Files           4         4              
  Lines         305       305              
===========================================
+ Hits          304       305       +1     
+ Misses          1         0       -1     
Impacted Files Coverage Δ
f8a_utils/dependency_finder.py 100.00% <0.00%> (ø)
f8a_utils/versions.py 100.00% <0.00%> (+0.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f45e6f...ca525fe. Read the comment docs.

@dgpatelgit dgpatelgit requested a review from arajkumar July 22, 2020 06:25
requirements.in Outdated Show resolved Hide resolved
@centos-ci
Copy link
Collaborator

@dgpatelgit Your image is available in the registry: docker pull MISSING_REGISTRY_NAME/MISSING_IMAGE_NAME:SNAPSHOT-PR-57

@centos-ci
Copy link
Collaborator

@dgpatelgit Your image is available in the registry: docker pull MISSING_REGISTRY_NAME/MISSING_IMAGE_NAME:SNAPSHOT-PR-57

@dgpatelgit dgpatelgit requested a review from prashbnair July 23, 2020 09:12
@centos-ci
Copy link
Collaborator

@dgpatelgit Your image is available in the registry: docker pull MISSING_REGISTRY_NAME/MISSING_IMAGE_NAME:SNAPSHOT-PR-57

requirements.in Outdated Show resolved Hide resolved
@centos-ci
Copy link
Collaborator

@dgpatelgit Your image is available in the registry: docker pull MISSING_REGISTRY_NAME/MISSING_IMAGE_NAME:SNAPSHOT-PR-57

@centos-ci
Copy link
Collaborator

@dgpatelgit Your image is available in the registry: docker pull MISSING_REGISTRY_NAME/MISSING_IMAGE_NAME:SNAPSHOT-PR-57

Copy link
Member

@arajkumar arajkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants