Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Unify python dependency installation and update to vulnerability free versions #912

Merged
merged 10 commits into from
Aug 20, 2020
Merged

Conversation

jparsai
Copy link
Contributor

@jparsai jparsai commented Jul 30, 2020

Description

  • Resolved vulnerabilities and used updated versions of the dependencies.
  • Moved any test specific packages from requirements.in to tests/requirements.in
  • Moved any direct pip installations from Dockerfile.* to requirements.in
  • Provided relative versioning in requirements.in & tests/requirements.in
  • Generated requirements.txt and tests/requirements.txt using pip compiler
  • Updated setup.py to use requirement.in

Issue

APPAI-1406/1409

@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@4e822f7). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #912   +/-   ##
=========================================
  Coverage          ?   64.53%           
=========================================
  Files             ?       73           
  Lines             ?     5377           
  Branches          ?        0           
=========================================
  Hits              ?     3470           
  Misses            ?     1907           
  Partials          ?        0           
Impacted Files Coverage Δ
f8a_worker/setup_celery.py 53.65% <0.00%> (ø)
f8a_worker/dispatcher/predicates.py 95.13% <0.00%> (ø)
f8a_worker/storages/s3_manifests.py 41.66% <0.00%> (ø)
f8a_worker/workers/finalize.py 34.61% <0.00%> (ø)
f8a_worker/dispatcher/trace.py 84.61% <0.00%> (ø)
f8a_worker/errors.py 100.00% <0.00%> (ø)
f8a_worker/storages/postgres.py 37.06% <0.00%> (ø)
f8a_worker/process.py 83.57% <0.00%> (ø)
f8a_worker/storages/s3_package_data.py 50.00% <0.00%> (ø)
f8a_worker/object_cache.py 48.64% <0.00%> (ø)
... and 63 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e822f7...f3051d2. Read the comment docs.

@centos-ci
Copy link
Collaborator

@jparsai Your image is available in the registry: docker pull quay.io/openshiftio/rhel-bayesian-cucos-worker:SNAPSHOT-PR-912

@arajkumar arajkumar changed the title Resolve vulnerabilities, unified dependency handling. fix: Unify python dependency installation and update to vulnerability free versions Jul 30, 2020
Dockerfile Outdated Show resolved Hide resolved
requirements.in Show resolved Hide resolved
requirements.in Outdated Show resolved Hide resolved
tests/requirements.in Outdated Show resolved Hide resolved
Dockerfile.rhel Outdated Show resolved Hide resolved
@centos-ci
Copy link
Collaborator

@jparsai Your image is available in the registry: docker pull quay.io/openshiftio/rhel-bayesian-cucos-worker:SNAPSHOT-PR-912

@centos-ci
Copy link
Collaborator

@jparsai Your image is available in the registry: docker pull quay.io/openshiftio/rhel-bayesian-cucos-worker:SNAPSHOT-PR-912

Copy link
Member

@arajkumar arajkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jparsai Can you please following the same procedure from fabric8-analytics/fabric8-analytics-utils#57 ? It has a check list to be followed for the dependency cleanup activity.

requirements.in Show resolved Hide resolved
requirements.in Show resolved Hide resolved
requirements.in Outdated Show resolved Hide resolved
requirements.in Outdated Show resolved Hide resolved
requirements.in Show resolved Hide resolved
@centos-ci
Copy link
Collaborator

@jparsai Your image is available in the registry: docker pull quay.io/openshiftio/rhel-bayesian-cucos-worker:SNAPSHOT-PR-912

requirements.in Outdated Show resolved Hide resolved
@centos-ci
Copy link
Collaborator

@jparsai Your image is available in the registry: docker pull quay.io/openshiftio/rhel-bayesian-cucos-worker:SNAPSHOT-PR-912

@centos-ci
Copy link
Collaborator

@jparsai Your image is available in the registry: docker pull quay.io/openshiftio/rhel-bayesian-cucos-worker:SNAPSHOT-PR-912

setup.py Outdated Show resolved Hide resolved
tests/requirements.in Show resolved Hide resolved
@centos-ci
Copy link
Collaborator

@jparsai Your image is available in the registry: docker pull quay.io/openshiftio/rhel-bayesian-cucos-worker:SNAPSHOT-PR-912

@jparsai jparsai requested a review from arajkumar August 20, 2020 07:40
Copy link
Member

@arajkumar arajkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants