You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi, I've been looking into an issue using the fabric client in a kubernetes cluster, where a NO_PROXY config rule including 10.0.0.0/8, appeared to be ignored in the client.
I think after looking at regex in the HttpClientUtils, it currently has no match for a single digit bit suffix. Adding a test example with cidr bit suffix <10 to the existing tests, seems to confirm this.
I should hopefully be able to raise a PR for this shortly.
Fabric8 Kubernetes Client version
5.10.2
Steps to reproduce
Configure a kubernetes client with NO_PROXY=10.0.0.0/8 and a HTTPS_PROXY=http://someproxy:433
Expected behavior
Expected: Any connections to ip addresses in the 10.0.0.0/8 range don't use the https proxy configured.
Actual: Connections to ips in the 10.0.0.0/8 range eg 10.0.100.1 are proxyied via the configured https proxy.
Runtime
Kubernetes (vanilla)
Kubernetes API Server version
1.25.3@latest
Environment
Linux
Fabric8 Kubernetes Client Logs
No response
Additional context
No response
The text was updated successfully, but these errors were encountered:
domwood
added a commit
to domwood/kubernetes-client
that referenced
this issue
Feb 5, 2023
Describe the bug
Hi, I've been looking into an issue using the fabric client in a kubernetes cluster, where a NO_PROXY config rule including 10.0.0.0/8, appeared to be ignored in the client.
I think after looking at regex in the HttpClientUtils, it currently has no match for a single digit bit suffix. Adding a test example with cidr bit suffix <10 to the existing tests, seems to confirm this.
I should hopefully be able to raise a PR for this shortly.
Fabric8 Kubernetes Client version
5.10.2
Steps to reproduce
Configure a kubernetes client with NO_PROXY=10.0.0.0/8 and a HTTPS_PROXY=http://someproxy:433
Expected behavior
Expected: Any connections to ip addresses in the 10.0.0.0/8 range don't use the https proxy configured.
Actual: Connections to ips in the 10.0.0.0/8 range eg 10.0.100.1 are proxyied via the configured https proxy.
Runtime
Kubernetes (vanilla)
Kubernetes API Server version
1.25.3@latest
Environment
Linux
Fabric8 Kubernetes Client Logs
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: