Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #4832 - Match cidr with bit suffix <10 #4833

Merged
merged 2 commits into from
Feb 10, 2023
Merged

Fix #4832 - Match cidr with bit suffix <10 #4833

merged 2 commits into from
Feb 10, 2023

Conversation

domwood
Copy link
Contributor

@domwood domwood commented Feb 5, 2023 •
edited by manusa
Loading

Description

Fix #4832

Alter the regex which is used to extract cidr ranges, which are then tested against the target master url. This change should allow for single digit suffixes eg 10.0.0.0/8 to be matched, where before it did not appear to be.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@manusa manusa added this to the 6.5.0 milestone Feb 9, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@manusa manusa merged commit d2a16ac into fabric8io:master Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manusa manusa manusa approved these changes

@oscerd oscerd oscerd approved these changes

@rohanKanojia rohanKanojia Awaiting requested review from rohanKanojia

@shawkins shawkins Awaiting requested review from shawkins

@sunix sunix Awaiting requested review from sunix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.5.0
Development

Successfully merging this pull request may close these issues.

NO_PROXY rule with CIDR containing a bit suffix <10 appears to be ignored in the fabric client
3 participants
@domwood @manusa @oscerd