fix for #2989 disable the native type id feature for yaml #2990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Kudos, SonarCloud Quality Gate passed! |
oscerd
approved these changes
Apr 14, 2021
rohanKanojia
approved these changes
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #2989 this addresses the creation of invalid yaml, when using subtypes. This is happening in the Strimzi project due to https://github.com/strimzi/strimzi-kafka-operator/blob/ab9df1d231c08ddfd5c947f7beddf963b77e7fec/api/src/main/java/io/strimzi/api/kafka/model/storage/Storage.java#L21
Type of change
Checklist