fix for #2989 disable the native type id feature for yaml

CHANGELOG.md

@@ -4,6 +4,8 @@
 
 #### Bugs
 
+* Fix #2989: serialization will generate valid yaml when using subtypes
+
 #### Improvements
 
 #### Dependency Upgrade

kubernetes-client/src/main/java/io/fabric8/kubernetes/client/utils/Serialization.java

@@ -19,6 +19,7 @@
 import com.fasterxml.jackson.core.type.TypeReference;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.fasterxml.jackson.dataformat.yaml.YAMLFactory;
+import com.fasterxml.jackson.dataformat.yaml.YAMLGenerator;
 import com.fasterxml.jackson.datatype.jsr310.JavaTimeModule;
 import io.fabric8.kubernetes.api.model.KubernetesResource;
 import io.fabric8.kubernetes.client.KubernetesClientException;
@@ -46,7 +47,7 @@ private Serialization() { }
   static {
     JSON_MAPPER.registerModule(new JavaTimeModule());
   }
-  private static final ObjectMapper YAML_MAPPER = new ObjectMapper(new YAMLFactory());
+  private static final ObjectMapper YAML_MAPPER = new ObjectMapper(new YAMLFactory().disable(YAMLGenerator.Feature.USE_NATIVE_TYPE_ID));
   private static final String DOCUMENT_DELIMITER = "---";
 
   public static ObjectMapper jsonMapper() {

kubernetes-client/src/test/java/io/fabric8/kubernetes/client/utils/SerializationTest.java

@@ -20,6 +20,8 @@
 import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.assertTrue;
 
+import com.fasterxml.jackson.annotation.JsonSubTypes;
+import com.fasterxml.jackson.annotation.JsonTypeInfo;
 import com.fasterxml.jackson.databind.node.BooleanNode;
 import com.fasterxml.jackson.databind.node.IntNode;
 import com.fasterxml.jackson.databind.node.TextNode;
@@ -162,4 +164,50 @@ void testSerializeYamlWithAlias() {
     assertEquals("python:3.7", pod.getSpec().getContainers().get(1).getImage());
     assertEquals(new Quantity("100m"), pod.getSpec().getContainers().get(1).getResources().getRequests().get("cpu"));
   }
+
+  @JsonTypeInfo(
+          use = JsonTypeInfo.Id.NAME,
+          include = JsonTypeInfo.As.EXISTING_PROPERTY,
+          property = "type"
+  )
+  @JsonSubTypes(
+      @JsonSubTypes.Type(value = Typed.class, name = "x")
+  )
+  public interface Typeable {
+
+      String getType();
+
+  }
+
+  public static class Typed implements Typeable {
+
+      @Override
+      public String getType() {
+          return "x";
+      }
+
+  }
+
+  public static class Root {
+
+      private Typeable typeable;
+
+      public Typeable getTypeable() {
+          return typeable;
+      }
+
+      public void setTypeable(Typeable typeable) {
+          this.typeable = typeable;
+      }
+  }
+
+  @Test
+  void testSerializeYamlWithJsonSubTypes() {
+      Root root = new Root();
+      root.setTypeable(new Typed());
+      assertEquals("---\n"
+              + "typeable:\n"
+              + "  type: \"x\"\n", Serialization.asYaml(root));
+  }
+
 }