Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compression with Yui Compressor broken #5778

Closed
pimpin opened this issue Jun 26, 2019 · 1 comment · Fixed by #5782
Closed

Compression with Yui Compressor broken #5778

pimpin opened this issue Jun 26, 2019 · 1 comment · Fixed by #5782
Labels
bug

Comments

@pimpin
Copy link
Contributor

pimpin commented Jun 26, 2019 •
edited
Loading

Version

at least from 3.0.0 and until 3.2.0

similar to #2934

Compression broken by usage of reserverd "char" variable name in getHeightOfChar here : https://github.com/fabricjs/fabric.js/blob/v3.0.0/dist/fabric.js#L25206

You can test it here : https://fr.piliapp.com/minify/yui-compressor/
pimpin added a commit to pimpin/fabric.js that referenced this issue Jun 26, 2019
@pimpin
Fix usage of reserved keywork char
c775fca 
Should fix fabricjs#5778
pimpin added a commit to pimpin/fabric.js that referenced this issue Jun 26, 2019
@pimpin
Rm reserved keyword char
979cce6 
Should fix fabricjs#5778
@pimpin pimpin mentioned this issue Jun 26, 2019
Closed
@asturur
Copy link
Member

asturur commented Jun 26, 2019

Please, open a pr over the latest master, swapping the word char in all the places you think is needed.
Update JSDOCS, but do not update the dist files.
Then i can rebuild and release again.

@asturur asturur added the bug label Jun 26, 2019
pimpin added a commit to pimpin/fabric.js that referenced this issue Jun 27, 2019
@pimpin
Rm reserved keyword char
d59669d 
Should fix fabricjs#5778
@pimpin pimpin mentioned this issue Jun 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rm reserved keyword char pimpin/fabric.js
2 participants
@pimpin @asturur