Rm reserved keyword char #5779
Rm reserved keyword char #5779
Conversation
|
Notice I did not actualy build the dist file but manually fix it. |
|
Hi @pimpin please open a PR only on the master branch, without committing to the dist file at all. |
| getHeightOfChar: function(line, char) { | ||
| return this.getValueOfPropertyAt(line, char, 'fontSize'); | ||
| getHeightOfChar: function(line, _char) { | ||
| return this.getValueOfPropertyAt(line, _char, 'fontSize'); |
There was a problem hiding this comment.
should also fix the JSDOC 3 lines above
There was a problem hiding this comment.
ok. LEts do that. Will you backport it and build all of 3.0.1 3.1.1 and 3.2.1 ?
|
i will put in 3.2.1 and if you really need i can do a one off backport and publish, but if ypir app works with 3.0 will work with 3.2.1 too |
|
Actually we are not sure it's working well with 3.0.0. We are upgrading from 1.5.0 and we did not complete all our checkup yet. |
|
1.5 wow..... my first big release as contributor. Fabric changed a lot. |
Should fix #5778