Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for skewing [$125] #726

Closed
woutercommandeur opened this issue Jun 28, 2013 · 7 comments · Fixed by #2549
Closed

Add support for skewing [$125] #726

woutercommandeur opened this issue Jun 28, 2013 · 7 comments · Fixed by #2549
Assignees
Labels

Comments

@woutercommandeur
Copy link
Contributor

As discussed in #95, this is the issue to support skewing, with the bounty attached

Things that need fixing:

  1. Skewing manual by controls / programmatically
  2. Skewing due to side / top stretching a group containing a rotated object

There is a $125 open bounty on this issue. Add to the bounty at Bountysource.

@kangax
Copy link
Member

kangax commented Jul 6, 2013

We also need to make sure that:

  1. SVG output is skewed correctly
  2. Skewing in SVG is parsed in Fabric correctly
  3. Skewing should only skew shape, leaving borders and controls intact

@asturur
Copy link
Member

asturur commented Oct 2, 2014

@kangax @Kienz
About skewing:

when you say "border and control intacts", you mean that the control box should remain squared , aligned horizontal and vertical , or the controlbox should be skewed too? ( like is happening for rotate ).

Also, would you like to have some control to skew it directly ( i don't know placed where ) or would you do by corners with combination of some keypress?

let me know.

@kangax
Copy link
Member

kangax commented Oct 2, 2014

Yep, controls should be intact so that user can still work with object without difficulties.

As for separate control for skewing... hard to say. I'm open to suggestions, but I would start with just support for skewing without any special controls. And then come up with smth later.

Do any other graphic applications provide skewing controls? How do they look?

Sent from my iPhone

On Oct 2, 2014, at 10:44, Andrea Bogazzi [email protected] wrote:

@kangax @Kienz
About skewing:

when you say "border and control intacts", you mean that the control box should remain squared , aligned horizontal and vertical , or the controlbox should be skewed too? ( like is happening for rotate ).

Also, would you like to have some control to skew it directly ( i don't know placed where ) or would you do by corners with combination of some keypress?

let me know.


Reply to this email directly or view it on GitHub.

@asturur
Copy link
Member

asturur commented Oct 2, 2014

i didn't check very deeply, but looks like they reuse the corners with some combo press action.
Of course skewing by variable is easy and already done.
For the control box i was a little bit troubling because it is immediate for rects, but not so easy for everything else. I found a way, but it has to be deeply integrated with all the classes.
I'll show you when is at least half working, for now just talking.
I try to do it properly

So we settle for the control box to stay square and not bend, ok?

like that: ( star screwed and control box not )
image

and not like that:
image

@kangax
Copy link
Member

kangax commented Oct 2, 2014

Yep. Exactly like the star.

On Thu, Oct 2, 2014 at 2:29 PM, Andrea Bogazzi [email protected]
wrote:

i didn't check very deeply, but looks like they reuse the corners with
some combo press action.
Of course skewing by variable is easy and already done.
For the control box i was a little bit troubling because it is immediate
for rects, but not so easy for everything else. I found a way, but it has
to be deeply integrated with all the classes.
I'll show you when is at least half working, for now just talking.
I try to do it properly

So we settle for the control box to stay square and not bend, ok?

like that: ( star screwed and control box not )
[image: image]
https://cloud.githubusercontent.com/assets/1194048/4490704/a284b744-4a2f-11e4-9ef2-c491ecbcd1de.png

and not like that:
[image: image]
https://cloud.githubusercontent.com/assets/1194048/4490682/49893822-4a2f-11e4-903a-ebd573189f0d.png


Reply to this email directly or view it on GitHub
#726 (comment).

@asturur
Copy link
Member

asturur commented Oct 7, 2014

Not easy at all :)

Svg import export is working good, skewing by parameter is working good.

But drawing the correct controlbox for something that is round and skewed is a real pain ( circles, ellipses, and paths for example ).

@asturur
Copy link
Member

asturur commented Aug 9, 2015

for whom still interested #2369 is advanced in functionalities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants