bug in group-transformation (scale one side + rotate) [$115 awarded]

[urs]

Hello!

Reproduction of the bug:

1. open kitchensink (http://kangax.github.com/fabric.js/kitchensink/)
2. add two rectangles
3. select both rectangles
4. scale one side (not both!) of the group
5. then grab a corner-handle and rotate the scaled group
6. deselect

the rectangles will jump around instead of remaining the scale and position the got in the group.

Can you fix that?

The $115 bounty on this issue has been claimed at Bountysource.

[kangax]

I can reproduce this too. Marking as bug.

[Maxmyd]

Hello,
Any news on this issue? Looks like it's still not fixed

[kangax]

I didn't have time to fix it yet.

[limitium]

Do you plan to fix this bug?

[woutercommandeur]

This problem is in _restoreObjectState, and even worse in the fact that fabric does not support skewing of objects at the moment. It becomes very clear when you add 2 rectangles, rotate one of them to 30 degrees or so. Then select both rectangles and scale one side. This wil effectively skew the rotated rectangle. Deselecting after scaling will make the rectangle resume it's original non-skewed form because there is currently no way to skew.

[gregtap]

How can we bid on tickets ? 💵

[kangax]

@coulix Through bountysource

@woutercommandeur I've been planning to add support for vertical and horizontal skewing sometime soon. The actual canvas implementation is easy (via transform matrix) but then we need to detect proper bounding box (expanding it by the length of side opposite to the angle). Also need to support this in SVG output, which I didn't look into yet.

[woutercommandeur]

I just added a pull request that fixes the jumping around, but not the skewing :)
How do I collect the bounty?

[frenck]

+1 for this fix!

[woutercommandeur]

The bounty for this is still rising, is the fix not good enough? (or should we create a feature request for skewing)

[kangax]

@woutercommandeur I wanted to keep it open till skewing is fixed. Not sure how easy it is to transfer bounties to another ticket. I also think you should get at least half of the existing bounty for fixing jumping issue (need to check bountysource on how we can make that happen)

[woutercommandeur]

@kangax Ok, probably should have closed this as soon as it was fixed and make a new ticket. But if we can transfer bounty then that will work. I don't want all of this since people are putting money on skewing.

[kangax]

How about we just ask folks who put bounties (@travispaul @Kienz @coulix) if skewing is still an issue. If it's not, I'll happily close this one and we'll open another one.

[woutercommandeur]

Skewing is an issue, and should be fixed, but was not part of the original bug, non-rotated objects in a group now behave correctly.

[kangax]

@woutercommandeur I'm not saying skewing is not an issue. I just want to know if those who put bounties expected it to be fixed too, since it was mentioned in the comments. Technically though, original bug doesn't mention it so it would be fair to close it.

[woutercommandeur]

@kangax ok. If bounty can't be transfered, I could always put half of the bounty on the new issue for skewing.

[travispaul]

Thanks @woutercommandeur,
+1 from me, I am ok with this, skewing was not in the original ticket and this is an improvement.

@kangax if I were to open a ticket and then put up a bounty, is it possible to specify that a unit test a company the fix, or should requesting a unit test be a separate issue/bounty? Just curious.

Thanks

[kangax]

Well, I try to always add unit tests when possible. But a lot of visual
behavior like dragging/rotating and things like border/corner offsets or
line widths, etc. are hard to unit test programmatically. In cases like
that, a visual/functional test is a nice addition, but not a requirement.

On Sat, Jun 15, 2013 at 6:25 PM, Travis Paul [email protected]:

Thanks @woutercommandeur https://github.com/woutercommandeur,
+1 from me, I am ok with this, skewing was not in the original ticket and
this is an improvement.

@kangax https://github.com/kangax if I were to open a ticket and then
put up a bounty, is it possible to specify that a unit test a company the
fix, or should requesting a unit test be a separate issue/bounty? Just
curious.

Thanks

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/95#issuecomment-19499083
.

[gregtap]

+1 as well

[Kienz]

@woutercommandeur I'm ok with this. Great work.
@kangax I think we can close this bug and open new one for skewing. Maybe someone will create bounties (woutercommandeur :-)).

[woutercommandeur]

:)

[kangax]

Perfect, thanks again @woutercommandeur

[basarat]

In case someone else has the same error : The group jumps around if we use this.canvas.setActiveGroup(group); and then click on some other group.

Fix : Use this.canvas.setActiveObject(group);