Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rm reserved keyword char #5779

Closed
wants to merge 2 commits into from
Closed

Rm reserved keyword char #5779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
979cce6
Rm reserved keyword char
pimpin Jun 26, 2019
698f987
Update dist file with fix
pimpin Jun 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dist/fabric.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25203,8 +25203,8 @@ fabric.Image.filters.BaseFilter.fromObject = function(object, callback) {
* @param {Number} char the character number
* @return {Number} fontSize of the character
*/
getHeightOfChar: function(line, char) {
return this.getValueOfPropertyAt(line, char, 'fontSize');
getHeightOfChar: function(line, _char) {
return this.getValueOfPropertyAt(line, _char, 'fontSize');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should also fix the JSDOC 3 lines above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. LEts do that. Will you backport it and build all of 3.0.1 3.1.1 and 3.2.1 ?

},

/**
Expand Down
4 changes: 2 additions & 2 deletions src/shapes/text.class.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -683,8 +683,8 @@
* @param {Number} char the character number
* @return {Number} fontSize of the character
*/
getHeightOfChar: function(line, char) {
return this.getValueOfPropertyAt(line, char, 'fontSize');
getHeightOfChar: function(line, _char) {
return this.getValueOfPropertyAt(line, _char, 'fontSize');
},

/**
Expand Down