Include error name in error chunks #32157
Merged
+31
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
eps1lon
commented
Jan 22, 2025
| } | ||
|
|
||
| export type ReactErrorInfoDev = { | ||
| +digest?: string, |
There was a problem hiding this comment.
We currently don't transport the digest in error values. I don't see why we shouldn't.
There was a problem hiding this comment.
Might be awkward with undefined vs not defined and it didn't really come up yet anyway.
|
Comparing: b000019...6cdf20c Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
eps1lon
force-pushed
the
flight-error-chunk-name
branch
from
3f1eb7e to
d4b0a1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #32116
resolveErrorDevis used for error values and error chunks. However, https://github.com/facebook/react/pull/32116only included the name in error values so error chunks were deserialized with anundefinedname e.g. when we fail to serialize the error message-- https://github.com/vercel/next.js/actions/runs/12872159135/job/35887113469?pr=75110#step:32:302
Included some types for error info that are shared between Client and Server to avoid these bugs where we only consider error values and not chunks in the future.