This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Adds abstractEffectsInAdditionalFunctions to the React component reconciler
#1320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebmarkbage
approved these changes
Jan 10, 2018
scripts/test-react.js
Outdated
| @@ -113,6 +114,10 @@ function runTestSuite(outputJsx) { | |||
| await runTest(directory, "simple.js"); | |||
| }); | |||
|
|
|||
| it.only("Simple 2", async () => { | |||
trueadm
force-pushed
the
react-pure-functions
branch
from
cdcddfc to
afd4cc2
Compare
This was referenced Jan 11, 2018
sebmarkbage
force-pushed
the
react-pure-functions
branch
from
9c40cc5 to
170fc7a
Compare
There was a problem hiding this comment.
@sebmarkbage is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
abstractEffectsInAdditionalFunctionsfeatures to the React component reconciler, so we can better handle bail-outs in React components due to abstract value effects. This PR also adds a test to demonstrate this working – which currently fails right now.