This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Don't error calling possibly non-functions in pure functions #1321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes one of the tests in #1320. |
sebmarkbage
force-pushed
the
callunknowntype
branch
from
414bb13 to
21bd845
Compare
hermanventer
approved these changes
Jan 11, 2018
NTillmann
approved these changes
Jan 11, 2018
As outlined in facebookarchive#1264 we know that it is safe to throw in an pure function since then the return value will be ignored and therefore its state doesn't matter. The only time it matters, is if there is a try/catch around it which we already warn about. This means that we don't have to error when calling a non-function. I also plan to add more of these cases like this. So I took the liberty to also move this category of tests into a separate folder.
sebmarkbage
force-pushed
the
callunknowntype
branch
from
21bd845 to
a891eac
Compare
|
Add another test where it is expected that the resulting functions will throw. |
There was a problem hiding this comment.
@sebmarkbage is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 17, 2018
Summary: Builds on top of #1321 Lets $Get succeed on abstract values. Property access is not safe on abstract object values because they could be getters with side-effects or might throw. However, this is safe in a pure function context. We just have to make sure we leak the object that might get passed to a getter. It is also safe to coerce a non-object abstract value to an object, since all it can do is throw. Closes #1322 Differential Revision: D6734870 Pulled By: sebmarkbage fbshipit-source-id: bfe7a61dc312577ec4cc8926d3191dcee4e28b61
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As outlined in #1264 we know that it is safe to throw in an pure function since then the return value will be ignored and therefore its state doesn't matter. The only time it matters, is if there is a try/catch/finally around it which we already warn about.
This means that we don't have to error when calling a non-function.
I also plan to add more of these cases like this. So I took the liberty to also move this category of tests into a separate folder.