Protect access to Task.taskStats_ with a lock #124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D30596015 fbshipit-source-id: 0ba9cb305b87d84632cc9acd2ca66029fb6bd066
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D30596015 |
|
This pull request has been merged in 0735a39. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 27, 2023
Summary: X-link: facebook/fboss#124 X-link: facebookincubator/reindeer#6 X-link: facebook/sapling#497 X-link: facebook/mvfst#284 X-link: facebook/wangle#212 Pull Request resolved: #3785 X-link: facebookexperimental/rust-shed#37 X-link: facebook/hhvm#9317 X-link: facebookexperimental/edencommon#6 X-link: facebookincubator/hsthrift#108 X-link: facebook/proxygen#436 X-link: facebookincubator/katran#183 X-link: facebook/openr#143 X-link: facebook/fbthrift#536 X-link: facebook/fb303#33 X-link: facebook/folly#1924 FBOSS OSS on-diff job is failing due to random test failures. Disabling the tests for now to avoid build breakages. Reviewed By: shri-khare Differential Revision: D42550176 fbshipit-source-id: a40a4d39c2176e4a201f6c49c6e7837c4c7c90e5
rui-mo
pushed a commit
to rui-mo/velox
that referenced
this pull request
Feb 8, 2023
rui-mo
pushed a commit
to rui-mo/velox
that referenced
this pull request
Feb 24, 2023
liujiayi771
pushed a commit
to liujiayi771/velox
that referenced
this pull request
Mar 3, 2023
liujiayi771
pushed a commit
to liujiayi771/velox
that referenced
this pull request
Mar 9, 2023
rui-mo
added a commit
to rui-mo/velox
that referenced
this pull request
Mar 17, 2023
… validation (facebookincubator#124) * add validation * fix c2r * fix fallback issue * support projection with iterator input * support batch scan validation * seperate filter and project * send input types through extension * fix * support agg validation * refine * add a config to control native validation * refine
liujiayi771
pushed a commit
to liujiayi771/velox
that referenced
this pull request
Apr 1, 2023
rui-mo
pushed a commit
to rui-mo/velox
that referenced
this pull request
Apr 23, 2023
zhouyuan
pushed a commit
to zhouyuan/velox
that referenced
this pull request
Jun 7, 2023
relative pr: Fix replace SparkSQL function facebookincubator#277 Support kPreceeding & kFollowing for window range frame type facebookincubator#287 support timestamp hash facebookincubator#269 Spark sum can overflow facebookincubator#101 Support float & double types in pmod function facebookincubator#157 Implement datetime functions in velox/sparksql. facebookincubator#81 Fix type check in MapFunction facebookincubator#273 Let function validation fail for lookaround pattern in RE2-based implementation facebookincubator#124 Register lpad/rpad functions for Spark SQL. facebookincubator#63 Support substring_index sql function facebookincubator#189 Fix First/Last aggregate functions intermediate type and support decimal facebookincubator#245 Support date_add spark sql function facebookincubator#144
Yohahaha
pushed a commit
to Yohahaha/velox
that referenced
this pull request
Jul 4, 2023
relative pr: Fix replace SparkSQL function facebookincubator#277 Support kPreceeding & kFollowing for window range frame type facebookincubator#287 support timestamp hash facebookincubator#269 Spark sum can overflow facebookincubator#101 Support float & double types in pmod function facebookincubator#157 Implement datetime functions in velox/sparksql. facebookincubator#81 Fix type check in MapFunction facebookincubator#273 Let function validation fail for lookaround pattern in RE2-based implementation facebookincubator#124 Register lpad/rpad functions for Spark SQL. facebookincubator#63 Support substring_index sql function facebookincubator#189 Fix First/Last aggregate functions intermediate type and support decimal facebookincubator#245 Support date_add spark sql function facebookincubator#144
chenxu14
pushed a commit
to chenxu14/velox
that referenced
this pull request
Jul 5, 2023
relative pr: Fix replace SparkSQL function facebookincubator#277 Support kPreceeding & kFollowing for window range frame type facebookincubator#287 support timestamp hash facebookincubator#269 Spark sum can overflow facebookincubator#101 Support float & double types in pmod function facebookincubator#157 Implement datetime functions in velox/sparksql. facebookincubator#81 Fix type check in MapFunction facebookincubator#273 Let function validation fail for lookaround pattern in RE2-based implementation facebookincubator#124 Register lpad/rpad functions for Spark SQL. facebookincubator#63 Support substring_index sql function facebookincubator#189 Fix First/Last aggregate functions intermediate type and support decimal facebookincubator#245 Support date_add spark sql function facebookincubator#144
PHILO-HE
pushed a commit
to PHILO-HE/velox
that referenced
this pull request
Jul 17, 2023
relative pr: Fix replace SparkSQL function facebookincubator#277 Support kPreceeding & kFollowing for window range frame type facebookincubator#287 support timestamp hash facebookincubator#269 Spark sum can overflow facebookincubator#101 Support float & double types in pmod function facebookincubator#157 Implement datetime functions in velox/sparksql. facebookincubator#81 Fix type check in MapFunction facebookincubator#273 Let function validation fail for lookaround pattern in RE2-based implementation facebookincubator#124 Register lpad/rpad functions for Spark SQL. facebookincubator#63 Support substring_index sql function facebookincubator#189 Fix First/Last aggregate functions intermediate type and support decimal facebookincubator#245 Support date_add spark sql function facebookincubator#144
rui-mo
pushed a commit
to rui-mo/velox
that referenced
this pull request
Jul 21, 2023
relative pr: Fix replace SparkSQL function facebookincubator#277 Support kPreceeding & kFollowing for window range frame type facebookincubator#287 support timestamp hash facebookincubator#269 Spark sum can overflow facebookincubator#101 Support float & double types in pmod function facebookincubator#157 Implement datetime functions in velox/sparksql. facebookincubator#81 Fix type check in MapFunction facebookincubator#273 Let function validation fail for lookaround pattern in RE2-based implementation facebookincubator#124 Register lpad/rpad functions for Spark SQL. facebookincubator#63 Support substring_index sql function facebookincubator#189 Fix First/Last aggregate functions intermediate type and support decimal facebookincubator#245 Support date_add spark sql function facebookincubator#144
rui-mo
pushed a commit
to rui-mo/velox
that referenced
this pull request
Jul 24, 2023
relative pr: Fix replace SparkSQL function facebookincubator#277 Support kPreceeding & kFollowing for window range frame type facebookincubator#287 support timestamp hash facebookincubator#269 Spark sum can overflow facebookincubator#101 Support float & double types in pmod function facebookincubator#157 Implement datetime functions in velox/sparksql. facebookincubator#81 Fix type check in MapFunction facebookincubator#273 Let function validation fail for lookaround pattern in RE2-based implementation facebookincubator#124 Register lpad/rpad functions for Spark SQL. facebookincubator#63 Support substring_index sql function facebookincubator#189 Fix First/Last aggregate functions intermediate type and support decimal facebookincubator#245 Support date_add spark sql function facebookincubator#144
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D30596015