Fix flaky task end state check #287
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A Task changes to kFinished state after producing all output and finishing the testing cursor. Therefore the test may rarely see the unfinished state even though the finished state will be set. Report incorrect end state after a wait.
facebook-github-bot
added
the
CLA Signed
mbasmanova
approved these changes
Sep 23, 2021
|
@oerling has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
zhouyuan
pushed a commit
to zhouyuan/velox
that referenced
this pull request
May 31, 2023
…kincubator#287) * Initial commit * Fix compile issue * Cherry pick PR 4510 * Fix issue in upstream PR * Fix bugs for unique sort key * Fix bugs for repeated sort key * Add more test cases * Fix int type issue * Handle null * Remove some commented code * Remove check null * Fix velox ut failure for rows frame * Format the code
zhouyuan
pushed a commit
to zhouyuan/velox
that referenced
this pull request
Jun 6, 2023
…kincubator#287) * Initial commit * Fix compile issue * Cherry pick PR 4510 * Fix issue in upstream PR * Fix bugs for unique sort key * Fix bugs for repeated sort key * Add more test cases * Fix int type issue * Handle null * Remove some commented code * Remove check null * Fix velox ut failure for rows frame * Format the code
zhouyuan
pushed a commit
to zhouyuan/velox
that referenced
this pull request
Jun 7, 2023
relative pr: Fix hashjoin runtime issue facebookincubator#106 INVALID_STATE on HashJoin when spill is turned on facebookincubator#154 SIGABRT on DecimalAvgAggregate<UnscaleLongDecimal, UnscaleShortDecimal> when spilling is engaged facebookincubator#236 Support kPreceeding & kFollowing for window range frame type facebookincubator#287
zhouyuan
pushed a commit
to zhouyuan/velox
that referenced
this pull request
Jun 7, 2023
relative pr: Fix replace SparkSQL function facebookincubator#277 Support kPreceeding & kFollowing for window range frame type facebookincubator#287 support timestamp hash facebookincubator#269 Spark sum can overflow facebookincubator#101 Support float & double types in pmod function facebookincubator#157 Implement datetime functions in velox/sparksql. facebookincubator#81 Fix type check in MapFunction facebookincubator#273 Let function validation fail for lookaround pattern in RE2-based implementation facebookincubator#124 Register lpad/rpad functions for Spark SQL. facebookincubator#63 Support substring_index sql function facebookincubator#189 Fix First/Last aggregate functions intermediate type and support decimal facebookincubator#245 Support date_add spark sql function facebookincubator#144
PHILO-HE
added a commit
to PHILO-HE/velox
that referenced
this pull request
Jun 27, 2023
…kincubator#287) * Initial commit * Fix compile issue * Cherry pick PR 4510 * Fix issue in upstream PR * Fix bugs for unique sort key * Fix bugs for repeated sort key * Add more test cases * Fix int type issue * Handle null * Remove some commented code * Remove check null * Fix velox ut failure for rows frame * Format the code
Yohahaha
pushed a commit
to Yohahaha/velox
that referenced
this pull request
Jul 4, 2023
relative pr: Fix hashjoin runtime issue facebookincubator#106 INVALID_STATE on HashJoin when spill is turned on facebookincubator#154 SIGABRT on DecimalAvgAggregate<UnscaleLongDecimal, UnscaleShortDecimal> when spilling is engaged facebookincubator#236 Support kPreceeding & kFollowing for window range frame type facebookincubator#287
Yohahaha
pushed a commit
to Yohahaha/velox
that referenced
this pull request
Jul 4, 2023
relative pr: Fix replace SparkSQL function facebookincubator#277 Support kPreceeding & kFollowing for window range frame type facebookincubator#287 support timestamp hash facebookincubator#269 Spark sum can overflow facebookincubator#101 Support float & double types in pmod function facebookincubator#157 Implement datetime functions in velox/sparksql. facebookincubator#81 Fix type check in MapFunction facebookincubator#273 Let function validation fail for lookaround pattern in RE2-based implementation facebookincubator#124 Register lpad/rpad functions for Spark SQL. facebookincubator#63 Support substring_index sql function facebookincubator#189 Fix First/Last aggregate functions intermediate type and support decimal facebookincubator#245 Support date_add spark sql function facebookincubator#144
chenxu14
pushed a commit
to chenxu14/velox
that referenced
this pull request
Jul 5, 2023
relative pr: Fix hashjoin runtime issue facebookincubator#106 INVALID_STATE on HashJoin when spill is turned on facebookincubator#154 SIGABRT on DecimalAvgAggregate<UnscaleLongDecimal, UnscaleShortDecimal> when spilling is engaged facebookincubator#236 Support kPreceeding & kFollowing for window range frame type facebookincubator#287
chenxu14
pushed a commit
to chenxu14/velox
that referenced
this pull request
Jul 5, 2023
relative pr: Fix replace SparkSQL function facebookincubator#277 Support kPreceeding & kFollowing for window range frame type facebookincubator#287 support timestamp hash facebookincubator#269 Spark sum can overflow facebookincubator#101 Support float & double types in pmod function facebookincubator#157 Implement datetime functions in velox/sparksql. facebookincubator#81 Fix type check in MapFunction facebookincubator#273 Let function validation fail for lookaround pattern in RE2-based implementation facebookincubator#124 Register lpad/rpad functions for Spark SQL. facebookincubator#63 Support substring_index sql function facebookincubator#189 Fix First/Last aggregate functions intermediate type and support decimal facebookincubator#245 Support date_add spark sql function facebookincubator#144
PHILO-HE
pushed a commit
to PHILO-HE/velox
that referenced
this pull request
Jul 17, 2023
relative pr: Fix hashjoin runtime issue facebookincubator#106 INVALID_STATE on HashJoin when spill is turned on facebookincubator#154 SIGABRT on DecimalAvgAggregate<UnscaleLongDecimal, UnscaleShortDecimal> when spilling is engaged facebookincubator#236 Support kPreceeding & kFollowing for window range frame type facebookincubator#287
PHILO-HE
pushed a commit
to PHILO-HE/velox
that referenced
this pull request
Jul 17, 2023
relative pr: Fix replace SparkSQL function facebookincubator#277 Support kPreceeding & kFollowing for window range frame type facebookincubator#287 support timestamp hash facebookincubator#269 Spark sum can overflow facebookincubator#101 Support float & double types in pmod function facebookincubator#157 Implement datetime functions in velox/sparksql. facebookincubator#81 Fix type check in MapFunction facebookincubator#273 Let function validation fail for lookaround pattern in RE2-based implementation facebookincubator#124 Register lpad/rpad functions for Spark SQL. facebookincubator#63 Support substring_index sql function facebookincubator#189 Fix First/Last aggregate functions intermediate type and support decimal facebookincubator#245 Support date_add spark sql function facebookincubator#144
rui-mo
pushed a commit
to rui-mo/velox
that referenced
this pull request
Jul 21, 2023
relative pr: Fix hashjoin runtime issue facebookincubator#106 INVALID_STATE on HashJoin when spill is turned on facebookincubator#154 SIGABRT on DecimalAvgAggregate<UnscaleLongDecimal, UnscaleShortDecimal> when spilling is engaged facebookincubator#236 Support kPreceeding & kFollowing for window range frame type facebookincubator#287
rui-mo
pushed a commit
to rui-mo/velox
that referenced
this pull request
Jul 21, 2023
relative pr: Fix replace SparkSQL function facebookincubator#277 Support kPreceeding & kFollowing for window range frame type facebookincubator#287 support timestamp hash facebookincubator#269 Spark sum can overflow facebookincubator#101 Support float & double types in pmod function facebookincubator#157 Implement datetime functions in velox/sparksql. facebookincubator#81 Fix type check in MapFunction facebookincubator#273 Let function validation fail for lookaround pattern in RE2-based implementation facebookincubator#124 Register lpad/rpad functions for Spark SQL. facebookincubator#63 Support substring_index sql function facebookincubator#189 Fix First/Last aggregate functions intermediate type and support decimal facebookincubator#245 Support date_add spark sql function facebookincubator#144
rui-mo
pushed a commit
to rui-mo/velox
that referenced
this pull request
Jul 24, 2023
relative pr: Fix hashjoin runtime issue facebookincubator#106 INVALID_STATE on HashJoin when spill is turned on facebookincubator#154 SIGABRT on DecimalAvgAggregate<UnscaleLongDecimal, UnscaleShortDecimal> when spilling is engaged facebookincubator#236 Support kPreceeding & kFollowing for window range frame type facebookincubator#287
rui-mo
pushed a commit
to rui-mo/velox
that referenced
this pull request
Jul 24, 2023
relative pr: Fix replace SparkSQL function facebookincubator#277 Support kPreceeding & kFollowing for window range frame type facebookincubator#287 support timestamp hash facebookincubator#269 Spark sum can overflow facebookincubator#101 Support float & double types in pmod function facebookincubator#157 Implement datetime functions in velox/sparksql. facebookincubator#81 Fix type check in MapFunction facebookincubator#273 Let function validation fail for lookaround pattern in RE2-based implementation facebookincubator#124 Register lpad/rpad functions for Spark SQL. facebookincubator#63 Support substring_index sql function facebookincubator#189 Fix First/Last aggregate functions intermediate type and support decimal facebookincubator#245 Support date_add spark sql function facebookincubator#144
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Task changes to kFinished state after producing all output and
finishing the testing cursor. Therefore the test may rarely see the
unfinished state even though the finished state will be set. Report
incorrect end state after a wait.