Fix past-the-end iteration. #231
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ienkovich <[email protected]>
facebook-github-bot
added
the
CLA Signed
kgpai
reviewed
Sep 16, 2021
| @@ -36,6 +36,9 @@ class ArgumentsCtx { | |||
| } | |||
|
|
|||
| bool operator==(const ArgumentsCtx& rhs) const { | |||
| if (types_.size() != rhs.types().size()) { | |||
There was a problem hiding this comment.
Can you add a test case and verify it works with nullptr ?
There was a problem hiding this comment.
Sorry, I don't get what you mean by nullptr here since added code doesn't work with pointers.
I want to fix a segfault which happens when vectors of different sizes are compared (in my case it fails to compare types for round(INTEGER, INTEGER) and round(INTEGER)). I simply cannot start Prestissimo server with the current main branch.
|
Fixed by #245 |
rui-mo
pushed a commit
to rui-mo/velox
that referenced
this pull request
Mar 17, 2023
Signed-off-by: Yuan Zhou <[email protected]>
rui-mo
pushed a commit
to rui-mo/velox
that referenced
this pull request
Mar 17, 2023
…tor#231)" (facebookincubator#243) This reverts commit 3ca08d7.
rui-mo
pushed a commit
to rui-mo/velox
that referenced
this pull request
Mar 17, 2023
…#231 (facebookincubator#691) add check_overflow transform support. test by CH[[231]]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.