Add properties to Connector #243
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
mbasmanova
approved these changes
Sep 20, 2021
velox/connectors/Connector.h
Outdated
| explicit Connector( | ||
| const std::string& id, | ||
| std::shared_ptr<const Config> properties) | ||
| : id_(id), properties_(properties) {} |
There was a problem hiding this comment.
nit: std::move to avoid unnecessary increment/decrement of the reference count
velox/connectors/Connector.h
Outdated
|
|
||
| virtual ~Connector() = default; | ||
|
|
||
| const std::string& connectorId() const { | ||
| return id_; | ||
| } | ||
|
|
||
| std::shared_ptr<const Config> connectorProperties() const { |
There was a problem hiding this comment.
using const & for the return value to avoid unnecessary increment/decrement of the reference count
velox/connectors/Connector.h
Outdated
| @@ -186,6 +193,7 @@ class Connector { | |||
|
|
|||
| private: | |||
| const std::string id_; | |||
| std::shared_ptr<const Config> properties_; | |||
velox/connectors/hive/FileHandle.h
Outdated
| @@ -61,7 +62,13 @@ using FileHandleCache = SimpleLRUCache<std::string, FileHandle>; | |||
| // Creates FileHandles via the Generator interface the CachedFactory requires. | |||
| class FileHandleGenerator { | |||
| public: | |||
| FileHandleGenerator() {} | |||
| FileHandleGenerator(std::shared_ptr<const Config> properties) | |||
| : properties_(properties) {} | |||
velox/connectors/hive/FileHandle.h
Outdated
| std::unique_ptr<FileHandle> operator()(const std::string& filename); | ||
|
|
||
| private: | ||
| std::shared_ptr<const Config> properties_; |
|
all review comments are addressed. Thanks. |
|
@mbasmanova has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 21, 2021
Summary: This PR adds a config to the Connector class. For HiveConnector, we pass the connector config. Pull Request resolved: #243 Reviewed By: pedroerp Differential Revision: D31054347 Pulled By: mbasmanova fbshipit-source-id: e3fe02599ae7a4128bc480595708a38dfe23e01e
rui-mo
pushed a commit
to rui-mo/velox
that referenced
this pull request
Mar 17, 2023
…tor#231)" (facebookincubator#243) This reverts commit 3ca08d7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a config to the Connector class.
For HiveConnector, we pass the connector config.