Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky task end state check #287

Closed
wants to merge 1 commit into from
Closed

Fix flaky task end state check #287

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion velox/exec/tests/DriverTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,23 @@ class DriverTest : public OperatorTestBase {
}
}

// Checks that 'task' transits to finished state within a short
// time. The finish takes place on a different thread after all
// results are produced and the cursor is at end, so that we may
// sometimes arrive at the check before the state change.
void expectFinished(std::shared_ptr<Task> task) {
constexpr int32_t kMaxWait = 5;
TaskState state;
for (auto i = 0; i < kMaxWait; ++i) {
state = task->state();
if (state == kFinished) {
break;
}
std::this_thread::sleep_for(std::chrono::milliseconds(1));
}
EXPECT_EQ(state, kFinished);
}

public:
// Sets 'future' to a future that will be realized within a random
// delay of a few ms.
Expand Down Expand Up @@ -400,7 +417,7 @@ TEST_F(DriverTest, pause) {
// Each thread will fully read the 1M rows in values.
EXPECT_EQ(numRead, 10 * hits);
EXPECT_TRUE(stateFutures_.at(0).isReady());
EXPECT_EQ(tasks_[0]->state(), kFinished);
expectFinished(tasks_[0]);
EXPECT_EQ(tasks_[0]->numDrivers(), 0);
const auto taskStats = tasks_[0]->taskStats();
ASSERT_EQ(taskStats.pipelineStats.size(), 1);
Expand Down