Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support dark mode for favicon #195

Merged
merged 1 commit into from
Jan 17, 2022
Merged

Conversation

antfu
Copy link
Contributor

@antfu antfu commented Jan 17, 2022

Before / After
image

@netlify
Copy link

netlify bot commented Jan 17, 2022

✔️ Deploy Preview for vigilant-wescoff-04e480 ready!

🔨 Explore the source changes: 1cbb20b

🔍 Inspect the deploy log: https://app.netlify.com/sites/vigilant-wescoff-04e480/deploys/61e526e3408822000807a984

😎 Browse the preview: https://deploy-preview-195--vigilant-wescoff-04e480.netlify.app

@Shinigami92
Copy link
Member

@antfu OH MY GOOD
Welcome ❤️

@Shinigami92 Shinigami92 added the p: 1-normal Nothing urgent label Jan 17, 2022
@Shinigami92 Shinigami92 added this to the v6.0.0 milestone Jan 17, 2022
@Shinigami92
Copy link
Member

Please not that we internally will also have a new logo. (#101)
But in the meantime, this is a welcome change 🙂

@JessicaSachs
Copy link
Contributor

Yes! I'm working on the magic panda. Welcome! 👋

@Shinigami92 Shinigami92 merged commit 156b76f into faker-js:main Jan 17, 2022
@poyea
Copy link

poyea commented Jan 17, 2022

Do we need a dark mode (perhaps a toggle) for the whole doc?

@Shinigami92
Copy link
Member

Do we need a dark mode (perhaps a toggle) for the whole doc?

I want that! Please create an issue for that.

Shinigami92 pushed a commit to MohdImran001/faker that referenced this pull request Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants