docs: adding new logo #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for vigilant-wescoff-04e480 ready! 🔨 Explore the source changes: 966f5d7 🔍 Inspect the deploy log: https://app.netlify.com/sites/vigilant-wescoff-04e480/deploys/61e71a9c40ad480008421662 😎 Browse the preview: https://deploy-preview-205--vigilant-wescoff-04e480.netlify.app |
ejcheng
previously approved these changes
Jan 18, 2022
ejcheng
added
c: docs
|
I hope it's not to late and not to much work, but can we move it a bit to the right? Feels a bit offset 😅 Twitter looks good IMO ✔️
|
|
Yeah I agree. Even though it’s technically even, it doesn’t look right. Let
me fix.
…On Tue, Jan 18, 2022 at 2:51 AM Shinigami ***@***.***> wrote:
I hope it's not to late and not to much work, but can we move it a bit to
the right? Feels a bit offset 😅
[image: image]
<https://user-images.githubusercontent.com/7195563/149893569-358e9eb1-eb95-4968-88c3-5a6d1a505010.png>
Twitter looks good IMO ✔️
[image: image]
<https://user-images.githubusercontent.com/7195563/149893644-6cc4e43b-5f3f-422f-95a4-bc757acbf623.png>
—
Reply to this email directly, view it on GitHub
<#205 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAVL4BHYELFNZEVWYEI2QLDUWULZTANCNFSM5MF5QPOA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Shinigami92
requested changes
Jan 18, 2022
|
The assets are actually centered. The Discord one may need to be re-uploaded. I think this is good to merge. |
Shinigami92
requested changes
Jan 18, 2022
|
I know. I was the one who added them, too, but that was before we had docs website and afterwards the README just didn’t look good. I can move it around if you want. |
Shinigami92
requested changes
Jan 18, 2022
Co-authored-by: Shinigami <[email protected]>
JessicaSachs
commented
Jan 18, 2022
Shinigami92
approved these changes
Jan 18, 2022
ejcheng
approved these changes
Jan 18, 2022
clarkerican
approved these changes
Jan 18, 2022
Shinigami92
added a commit
to MohdImran001/faker
that referenced
this pull request
Jan 18, 2022
Co-authored-by: Shinigami <[email protected]>
pkuczynski
pushed a commit
to pkuczynski/faker
that referenced
this pull request
Jan 21, 2022
Co-authored-by: Shinigami <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #101 :-)
I’ll put some of the twitter assets here, but they’re not getting committed.
Logo + Favicon
Twitter Banner
Fonts
Header: Sukar Black
Sans Serif: Raleway
Mono: Fira Code
I need help to add dark mode back into the favicon. #195. I tried to make some (bad) ones. Help from someone would be lovely.
