Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: align variable naming style of internet user agent #3314

Closed
wants to merge 1 commit into from

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Dec 3, 2024

@ST-DDT ST-DDT added c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent m: internet Something is referring to the internet module labels Dec 3, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Dec 3, 2024
@ST-DDT ST-DDT requested review from a team December 3, 2024 10:25
@ST-DDT ST-DDT self-assigned this Dec 3, 2024
Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit c455524
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/674edcbac29c4d0007a9654f
😎 Deploy Preview https://deploy-preview-3314.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.

Project coverage is 99.96%. Comparing base (ecb5cb4) to head (c455524).
Report is 3 commits behind head on next.

Files with missing lines Patch % Lines
src/modules/internet/user-agent.ts 90.47% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3314      +/-   ##
==========================================
- Coverage   99.97%   99.96%   -0.02%     
==========================================
  Files        2806     2806              
  Lines      217137   217137              
  Branches      985      974      -11     
==========================================
- Hits       217076   217054      -22     
- Misses         61       83      +22     
Files with missing lines Coverage Δ
src/modules/internet/user-agent.ts 91.92% <90.47%> (-7.70%) ⬇️

... and 1 file with indirect coverage changes

@ST-DDT
Copy link
Member Author

ST-DDT commented Dec 5, 2024

@ST-DDT ST-DDT closed this Dec 5, 2024
@ST-DDT ST-DDT deleted the coding-style/internet/user-agent branch December 5, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: chore PR that doesn't affect the runtime behavior m: internet Something is referring to the internet module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant