Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve parameter naming of keys.ts #3318

Closed
wants to merge 1 commit into from

Conversation

@ST-DDT ST-DDT added c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent labels Dec 3, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Dec 3, 2024
@ST-DDT ST-DDT requested review from a team December 3, 2024 10:41
@ST-DDT ST-DDT self-assigned this Dec 3, 2024
Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit ec6bf50
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/674ee05e55fe6400087b6e8a
😎 Deploy Preview https://deploy-preview-3318.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (ecb5cb4) to head (ec6bf50).
Report is 3 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3318      +/-   ##
==========================================
- Coverage   99.97%   99.96%   -0.01%     
==========================================
  Files        2806     2806              
  Lines      217137   217137              
  Branches      985      976       -9     
==========================================
- Hits       217076   217056      -20     
- Misses         61       81      +20     
Files with missing lines Coverage Δ
src/internal/keys.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@xDivisionByZerox
Copy link
Member

I'm not sure about this change since I don't see any advantage in this parameter name change. Just like i is an acceptable abbreviated variable name for counting in itterations, obj is perfectly fine for arguments that represent a gerneric object IMO.

If we would like to completly activate the the prevent-abbreviations rule I'd propably not argue. But sice we are not, I don't see a reason to change this part of our code.

@ST-DDT ST-DDT closed this Dec 4, 2024
@ST-DDT ST-DDT deleted the coding-style/internal/keys branch December 4, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants