Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated comment from development dependencies #2568

Merged
merged 2 commits into from
Sep 23, 2022

Conversation

stefannibrasil
Copy link
Contributor

Summary

Second part of #2524.

This comment is outdated and can be removed. This marks the end of #2522 where the goal is to keep Faker updated.

Dany Marcoux and others added 2 commits September 22, 2022 21:09
The version of the dependency i18n has to be at least 1.8.11, so this
`require` can be safely removed.
@stefannibrasil stefannibrasil merged commit 3f80dbc into master Sep 23, 2022
@stefannibrasil stefannibrasil deleted the i18n-comments branch September 23, 2022 04:22
sudeeptarlekar pushed a commit to sudeeptarlekar/faker that referenced this pull request Oct 7, 2022
* Remove unneeded require in lib/faker.rb

The version of the dependency i18n has to be at least 1.8.11, so this
`require` can be safely removed.

* This comment is not relevant anymore

Co-authored-by: Dany Marcoux <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant