Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated comment from development dependencies #2568

Merged
merged 2 commits into from
Sep 23, 2022
Merged

Remove outdated comment from development dependencies #2568

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef9cd50
Remove unneeded require in lib/faker.rb
Sep 3, 2022
24e399b
This comment is not relevant anymore
Sep 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions faker.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,7 @@ Gem::Specification.new do |spec|
spec.metadata['yard.run'] = 'yri'
spec.metadata['rubygems_mfa_required'] = 'true'

# Requires Ruby I18n 1.8.11 or higher to resolve https://github.com/faker-ruby/faker/issues/2330.
spec.add_dependency('i18n', '>= 1.8.11', '< 2')

spec.add_development_dependency('minitest', '5.16.3')
spec.add_development_dependency('pry', '0.14.1')
spec.add_development_dependency('rake', '13.0.6')
Expand Down
1 change: 0 additions & 1 deletion lib/faker.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

require 'psych'
require 'i18n'
require 'set' # Fixes a bug in i18n 0.6.11

Dir.glob(File.join(mydir, 'helpers', '*.rb')).sort.each { |file| require file }

Expand Down