Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(OWNERS): move inactive maintainers to emeritus approvers #151

Merged
merged 2 commits into from
Jul 18, 2022

Conversation

jasondellaluce
Copy link
Contributor

What type of PR is this?

/kind documentation

Any specific area of the project related to this PR?

What this PR does / why we need it:

For falcosecurity/evolution#157 (see: falcosecurity/evolution#157), this PR proposes to move to emeritus_approvers maintainers that have been inactive in the past 6 months, as for our governance (see: https://github.com/falcosecurity/.github/blob/master/GOVERNANCE.md#project-inactivity). Maintainers are invited to have a discussion and take a decision.

cc @falcosecurity/community-maintainers

Which issue(s) this PR fixes:

Special notes for your reviewer:

@poiana
Copy link

poiana commented Jul 14, 2022

@jasondellaluce: The label(s) kind/documentation cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind documentation

Any specific area of the project related to this PR?

What this PR does / why we need it:

For falcosecurity/evolution#157 (see: falcosecurity/evolution#157), this PR proposes to move to emeritus_approvers maintainers that have been inactive in the past 6 months, as for our governance (see: https://github.com/falcosecurity/.github/blob/master/GOVERNANCE.md#project-inactivity). Maintainers are invited to have a discussion and take a decision.

cc @falcosecurity/community-maintainers

Which issue(s) this PR fixes:

Special notes for your reviewer:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leogr
Copy link
Member

leogr commented Jul 14, 2022

Although this repository has not required much involvement, I'm ok with moving those owners to emeritus approvers because they egregiously served the Falco project in the past, but now it seems they don't have time anymore.

However, I don't feel comfortable remaining the only approver on the list. So I want to call in this discussion some other active maintainers I know have been very present in the community.

@araujof @terylt @cpanato @maxgio92 @Issif @dwindsor: Is anyone willing to step up as a maintainer of this repository? 🤗

Ofc, the invite is also open to any maintainer interested in managing this repo 😃

@Issif
Copy link
Member

Issif commented Jul 14, 2022

I'll propose myself as maintainer in a next community call if people agree

@Andreagit97
Copy link
Member

Andreagit97 commented Jul 14, 2022

Hey @leogr if you need help, I can do it! Let me know if you need it :)

@terylt
Copy link

terylt commented Jul 14, 2022

I'm happy to help maintain this if you want.

@maxgio92
Copy link
Member

I'm happy to help here too @leogr. At the same time, as community calls are one of the best places where the whole community meets IMHO, and I join them infrequently, I don't see I match the duties of a potential community maintainer.

@araujof
Copy link
Member

araujof commented Jul 14, 2022

@leogr same here, if you guys need one more pair of hands, I volunteer to help :)

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jasondellaluce,

Could you apply my suggested change (see below) please? Thank you 🙏

Then I believe we are mostly done here.

OWNERS Show resolved Hide resolved
Signed-off-by: Jason Dellaluce <[email protected]>

Co-authored-by: Leonardo Grasso <[email protected]>
@leogr leogr changed the title update(OWNERS): move inactive maintainers to emeritus approvers wip: update(OWNERS): move inactive maintainers to emeritus approvers Jul 15, 2022
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change LGTM since:

  • people moved to emeritus_approvers have been inactive but also
    • decided to step down,
    • have not shown interest in maintaining this repo,
    • are unreachable,
    • or already left the organization;
  • new people added to approvers
    • are already maintainers of other projects
    • have been involved in the community;
  • this is a special repo, but it does not require much maintenance, and no particular requirements are needed.

I've added the wip: prefix (i.e. work in progress) to this PR to make clear that the current proposed change is not yet a definitive decision. So, I leave this open another couple of days in case there's other feedback. However, you can still propose changes even after this PR gets merged.

@leogr leogr changed the title wip: update(OWNERS): move inactive maintainers to emeritus approvers update(OWNERS): move inactive maintainers to emeritus approvers Jul 18, 2022
@poiana
Copy link

poiana commented Jul 18, 2022

LGTM label has been added.

Git tree hash: aad43639fe1cdc2d73e3da07441b239979fdade5

@poiana
Copy link

poiana commented Jul 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasondellaluce, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 8af9a0a into falcosecurity:master Jul 18, 2022
@jasondellaluce jasondellaluce deleted the patch-2 branch July 18, 2022 13:59
@leogr leogr mentioned this pull request Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants