Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tracking] cleanup inactive maintainers #157

Closed
17 tasks done
Tracked by #2106 ...
jasondellaluce opened this issue Jul 5, 2022 · 22 comments
Closed
17 tasks done
Tracked by #2106 ...

[tracking] cleanup inactive maintainers #157

jasondellaluce opened this issue Jul 5, 2022 · 22 comments
Labels
kind/feature New feature or request

Comments

@jasondellaluce
Copy link
Contributor

jasondellaluce commented Jul 5, 2022

Motivation

As part of the preparations for our graduation submission, this issue tracks the process of reviewing and cleaning up the OWNERS files of each repository. This is a step for falcosecurity/falco#2106 and follows the community call discussion of 2022-06-29.

The OWNERS files of each repository will be updated to remove maintainers that have been inactive for the past 6 months as for the criteria of our governance (see: https://github.com/falcosecurity/.github/blob/master/GOVERNANCE.md#project-inactivity).

Developer activity is reviewed from the https://devstats.cncf.io/ API (ref: https://github.com/cncf/devstatscode/blob/master/API.md, https://github.com/cncf/devstatscode/blob/master/devel/api_dev_act_cnt.sh). Inactivity means having recorded zero or very little devstats over the past 6 months (2022-01-01 - 2022-07-01).

Inactive maintainers will be moved from approvers to emeritus_approvers (see: https://www.kubernetes.dev/docs/guide/owners/#emeritus) so that they will have the possibility to step up again in the future.

If any of the maintainers involved wishes to continue with their role, or to become active again, this issue (or any of its linked PRs) is the right place of discussion.

These repositories are excluded from the rewiew:

  • Special repositories (see: [tracking] cleanup inactive maintainers #157 (comment))
  • Repositories opened less than 6 months ago
    • falcosecurity/deploy-kubernetes
    • falcosecurity/kernel-crawler
    • falcosecurity/plugin-sdk-cpp
    • falcosecurity/falco-aws-terraform
    • falcosecurity/libs-sdk-go
  • Repositories that had no activity (or very little) in the past 6 months
    • falcosecurity/katacoda-scenarios
    • falcosecurity/client-py
    • falcosecurity/client-rs
    • falcosecurity/kilt
    • falcosecurity/pdig

Repositories where inactive owners need to be updated

@markjacksonfishing
Copy link

Ack @jasondellaluce

@fntlnz
Copy link
Contributor

fntlnz commented Jul 6, 2022

Citing our governance:

If they decide to step down they open a pull request to be removed from the OWNERS files.

I did not decide to step down. It’s important for me to keep being a maintainer of Falco to ensure that our community has a different voice out there than employees of a single company. When I will see a diverse pool of maintainers I will think about stepping down. Even in that case, it’s a decision I will take based on the status of the project. I’m continuing to serve the community by making sure that the project is openly governed.

Please make sure to not remove my name from the approver files.

@leodido
Copy link
Member

leodido commented Jul 6, 2022

Citing our governance:

If they decide to step down they open a pull request to be removed from the OWNERS files.

I did not decide to step down. It’s important for me to keep being a maintainer of Falco to ensure that our community has a different voice out there than employees of a single company. When I will see a diverse pool of maintainers I will think about stepping down. Even in that case, it’s a decision I will take based on the status of the project. I’m continuing to serve the community by making sure that the project is openly governed.

Please make sure to not remove my name from the approver files.

Likewise. Same for me.

@nestorsalceda
Copy link

Citing our governance:

If they decide to step down they open a pull request to be removed from the OWNERS files.

I did not decide to step down. It’s important for me to keep being a maintainer of Falco to ensure that our community has a different voice out there than employees of a single company. When I will see a diverse pool of maintainers I will think about stepping down. Even in that case, it’s a decision I will take based on the status of the project. I’m continuing to serve the community by making sure that the project is openly governed.

Please make sure to not remove my name from the approver files.

I do agree with @fntlnz and @leodido

Same for me.

@maxgio92
Copy link
Member

maxgio92 commented Jul 6, 2022

IMHO there is an ambiguity in this sentence:

If they decide to step down they [1] open a pull request to be removed from the OWNERS files.

  1. Active maintainers or inactive maintainers?

@fntlnz
Copy link
Contributor

fntlnz commented Jul 6, 2022

@maxgio92 no ambiguity, please read the whole thing

Any existing maintainer that does not show significant activity on the project they maintain can be removed. Periodically, maintainers review the list of maintainers and their activity during the past six months.
In case the maintainer involvement in the past six months doesn't meet the requirements in this file they will be contacted to ask wether they want to continue being a maintainer. If they decide to step down they open a pull request to be removed from the OWNERS files.

Again, In my case I don't consider myself inactive. I'm less active than others but it's no justification to single-handedly
remove me from a project that I know like my pockets and where I am and will be always useful - because I'm here to help.

@leodido
Copy link
Member

leodido commented Jul 6, 2022

IMHO there is an ambiguity in this sentence:

If they decide to step down they [1] open a pull request to be removed from the OWNERS files.

1. Active maintainers or inactive maintainers?

I think there's no ambiguity at all. ⬇️

they will be contacted to ask whether they want to continue being a maintainer. If they ...

@fntlnz
Copy link
Contributor

fntlnz commented Jul 6, 2022

@leodido

they will be contacted to ask whether they want to continue being a maintainer.

No evidence of being contacted from my side as well.

@markjacksonfishing
Copy link

I can also say other than being tagged in this, there has been no contact with me.
I was originally removed under the same circumstances previously and aired my concerns over that.
I would like to remain as well.

@maxgio92
Copy link
Member

maxgio92 commented Jul 6, 2022

I agree on the fact that the contact is a requirement. I wasn't aware it has been missed.

Maybe a clarification on what is considered inactivity can help on the governance?
Also, how a maintainer should be contacted, to avoid mistakes (e.g. maintainer email?).

@leodido
Copy link
Member

leodido commented Jul 6, 2022

This is not the place to discuss changes to the governance (there's a process for that in the governance itself).

@krisnova
Copy link
Contributor

krisnova commented Jul 14, 2022

Please see falcosecurity/falco#2132 where I believe we can migrate some of the existing approvers to a new role.

@jasondellaluce
Copy link
Contributor Author

As @leogr suggested in some of the related PRs and issues, I agree on moving this discussion to falcosecurity/evolution.

Quoting the readme of the evolution repository:

This repo aims to document the evolution process of The Falco Project.

Since this issue covers many PRs across the organization, and not just the falco repository, I'd ask @leogr or some other maintainer of both repositories to move this issue to falcosecurity/evolution.

@leogr
Copy link
Member

leogr commented Jul 18, 2022

Since this issue covers many PRs across the organization, and not just the falco repository, I'd ask @leogr or some other maintainer of both repositories to move this issue to falcosecurity/evolution.

Sure 👍

Moving it right now.

@jasondellaluce
Copy link
Contributor Author

Closing this issue as the checklist is now complete.

/close

@poiana poiana closed this as completed Jul 20, 2022
@poiana
Copy link
Contributor

poiana commented Jul 20, 2022

@jasondellaluce: Closing this issue.

In response to this:

Closing this issue as the checklist is now complete.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

leogr added a commit to falcosecurity/test-infra that referenced this issue Jul 22, 2022
As a consequence of the inactive maintainers' review, some members of the organization are not `approvers` nor `reviewers` anymore. See falcosecurity/evolution#157

Since this file has been manually synched, please contact us in case of any errors.

Signed-off-by: Leonardo Grasso <[email protected]>
poiana pushed a commit to falcosecurity/test-infra that referenced this issue Jul 22, 2022
As a consequence of the inactive maintainers' review, some members of the organization are not `approvers` nor `reviewers` anymore. See falcosecurity/evolution#157

Since this file has been manually synched, please contact us in case of any errors.

Signed-off-by: Leonardo Grasso <[email protected]>
maxgio92 pushed a commit that referenced this issue Sep 8, 2022
As a consequence of the inactive maintainers' review, some members of the organization are not `approvers` nor `reviewers` anymore. See #157

Since this file has been manually synched, please contact us in case of any errors.

Signed-off-by: Leonardo Grasso <[email protected]>
maxgio92 pushed a commit that referenced this issue Sep 22, 2022
As a consequence of the inactive maintainers' review, some members of the organization are not `approvers` nor `reviewers` anymore. See #157

Since this file has been manually synched, please contact us in case of any errors.

Signed-off-by: Leonardo Grasso <[email protected]>
maxgio92 pushed a commit that referenced this issue Sep 22, 2022
As a consequence of the inactive maintainers' review, some members of the organization are not `approvers` nor `reviewers` anymore. See #157

Since this file has been manually synched, please contact us in case of any errors.

Signed-off-by: Leonardo Grasso <[email protected]>
maxgio92 pushed a commit that referenced this issue Jan 17, 2023
As a consequence of the inactive maintainers' review, some members of the organization are not `approvers` nor `reviewers` anymore. See #157

Since this file has been manually synched, please contact us in case of any errors.

Signed-off-by: Leonardo Grasso <[email protected]>
maxgio92 pushed a commit to maxgio92/evolution that referenced this issue May 26, 2023
As a consequence of the inactive maintainers' review, some members of the organization are not `approvers` nor `reviewers` anymore. See falcosecurity#157

Since this file has been manually synched, please contact us in case of any errors.

Signed-off-by: Leonardo Grasso <[email protected]>
maxgio92 pushed a commit to maxgio92/evolution that referenced this issue Jun 20, 2023
As a consequence of the inactive maintainers' review, some members of the organization are not `approvers` nor `reviewers` anymore. See falcosecurity#157

Since this file has been manually synched, please contact us in case of any errors.

Signed-off-by: Leonardo Grasso <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

No branches or pull requests

9 participants