Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(OWNERS): remove inactive approvers #73

Closed
wants to merge 2 commits into from

Conversation

jasondellaluce
Copy link
Contributor

What type of PR is this?

/kind cleanup

/kind documentation

Any specific area of the project related to this PR?

/area pkg

What this PR does / why we need it:

For falcosecurity/evolution#157, this PR moves inactive approvers (who had very little or zero contributions over the past 6 months) from approvers to emeritus_approvers in OWNERS.

Which issue(s) this PR fixes:

Special notes for your reviewer:

@poiana poiana added kind/cleanup dco-signoff: yes kind/documentation Improvements or additions to documentation area/pkg labels Jul 5, 2022
@poiana
Copy link

poiana commented Jul 5, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jasondellaluce
To complete the pull request process, please assign leodido after the PR has been reviewed.
You can assign the PR to them by writing /assign @leodido in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

@fntlnz fntlnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leogr leogr requested a review from fntlnz July 13, 2022 14:01
@jasondellaluce
Copy link
Contributor Author

@fntlnz, given falcosecurity/falco#2122 I understand that you'd like to step down as maintainer of this repository, so can you please remove your Change Request so that other maintainers can proceed?

This PR is overlapping with the falcosecurity/falco#74 that you opened, so if you prefer to proceed with that one please sign-off your commit to unblock the DCO.

Of the two, I would prefer proceeding with this one that puts your name under the emeritus_approvers section instead of removing you from OWNERS entirely. Looking forward to hearing back from you.

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been on hold for 12 days now and it is still blocked because of the pending "change requests". However, @FedeDP and I agree to merge it.
@jasondellaluce could I ask to recreate this PR from scratch so that we can merge it, please?

Thank you in advance.

@jasondellaluce
Copy link
Contributor Author

This PR has been on hold for 12 days now and it is still blocked because of the pending "change requests". However, @FedeDP and I agree to merge it. @jasondellaluce could I ask to recreate this PR from scratch so that we can merge it, please?

Thank you in advance.

Closing this in favor of #76.

/close

@poiana poiana closed this Jul 18, 2022
@poiana
Copy link

poiana commented Jul 18, 2022

@jasondellaluce: Closed this PR.

In response to this:

This PR has been on hold for 12 days now and it is still blocked because of the pending "change requests". However, @FedeDP and I agree to merge it. @jasondellaluce could I ask to recreate this PR from scratch so that we can merge it, please?

Thank you in advance.

Closing this in favor of #76.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jasondellaluce jasondellaluce deleted the patch-1 branch July 18, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants