Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(OWNERS): move inactive maintainers to emeritus approvers #155

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

jasondellaluce
Copy link
Contributor

@jasondellaluce jasondellaluce commented Jul 14, 2022

What type of PR is this?

/kind documentation

Any specific area of the project related to this PR?

What this PR does / why we need it:

For #157 (see: #157), this PR proposes to move to emeritus_approvers maintainers that have been inactive in the past 6 months, as for our governance (see: https://github.com/falcosecurity/.github/blob/master/GOVERNANCE.md#project-inactivity). Maintainers are invited to have a discussion and take a decision.

cc @falcosecurity/evolution-maintainers

Which issue(s) this PR fixes:

Special notes for your reviewer:

@poiana poiana added kind/documentation Improvements or additions to documentation dco-signoff: yes labels Jul 14, 2022
@poiana poiana requested review from fntlnz and maxgio92 July 14, 2022 09:52
@poiana poiana added the size/XS label Jul 14, 2022
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, for me. I am just waiting for @maxgio92's opinion.

@maxgio92
Copy link
Member

maxgio92 commented Jul 14, 2022

Hi all, as per the discussion on the governance, even though this PR is not a perfect place for a discussion, I'd like to hear from the current maintainers @kris-nova @fntlnz @leodido @nestorsalceda if you'd like to keep going on this repo or not :-)

@maxgio92 maxgio92 closed this Jul 14, 2022
@maxgio92 maxgio92 reopened this Jul 14, 2022
@leogr leogr mentioned this pull request Jul 19, 2022
@maxgio92
Copy link
Member

/lgtm @leogr

@poiana
Copy link
Contributor

poiana commented Jul 19, 2022

LGTM label has been added.

Git tree hash: d339fb7e6b4e3e2ce9d4515fe836007aa330ce89

@poiana
Copy link
Contributor

poiana commented Jul 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasondellaluce, leogr, maxgio92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit de4afbf into falcosecurity:master Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants