Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates regarding falco packages #153

Merged
merged 10 commits into from
Feb 28, 2020
Merged

updates regarding falco packages #153

merged 10 commits into from
Feb 28, 2020

Conversation

leodido
Copy link
Member

@leodido leodido commented Feb 26, 2020

What type of PR is this?

/kind content

Any specific area of the project related to this PR?

/area documentation

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

leodido and others added 6 commits February 26, 2020 19:29
Co-authored-by: Lorenzo Fontana <[email protected]>
Signed-off-by: Leonardo Di Donato <[email protected]>
Co-authored-by: Lorenzo Fontana <[email protected]>
Signed-off-by: Leonardo Di Donato <[email protected]>
Co-authored-by: Lorenzo Fontana <[email protected]>
Signed-off-by: Leonardo Di Donato <[email protected]>
…co packages from the current master

Co-authored-by: Lorenzo Fontana <[email protected]>
Signed-off-by: Leonardo Di Donato <[email protected]>
@leodido
Copy link
Member Author

leodido commented Feb 26, 2020

/cc @kris-nova

@poiana poiana requested a review from krisnova February 26, 2020 18:29
Co-authored-by: Lorenzo Fontana <[email protected]>
Signed-off-by: Leonardo Di Donato <[email protected]>
leodido and others added 2 commits February 27, 2020 22:28
Co-authored-by: Lorenzo Fontana <[email protected]>
Signed-off-by: Leonardo Di Donato <[email protected]>
@fntlnz
Copy link
Contributor

fntlnz commented Feb 28, 2020

Looks like bintray can't sign the rpm packages automatically even when told so:

wget https://dl.bintray.com/falcosecurity/rpm/falco-0.20.0+d77080a-x86_64.rpm
rpm -qpi *.rpm | awk '/Signature/'

gives:

Signature   : (none)

Co-authored-by: Lorenzo Fontana <[email protected]>
Signed-off-by: Leonardo Di Donato <[email protected]>
@leodido
Copy link
Member Author

leodido commented Feb 28, 2020

Looks like bintray can't sign the rpm packages automatically even when told so:

wget https://dl.bintray.com/falcosecurity/rpm/falco-0.20.0+d77080a-x86_64.rpm
rpm -qpi *.rpm | awk '/Signature/'

gives:

Signature   : (none)

Solved ✔️

Copy link
Contributor

@fntlnz fntlnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@poiana
Copy link

poiana commented Feb 28, 2020

LGTM label has been added.

Git tree hash: e07802f6bd6d6aff24a343ea1587fd9aad1464af

@poiana
Copy link

poiana commented Feb 28, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fntlnz fntlnz changed the title wip: updates regarding falco packages updates regarding falco packages Feb 28, 2020
@poiana poiana merged commit fabfe7c into master Feb 28, 2020
@poiana poiana deleted the new/falco-packages branch February 28, 2020 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants