Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build, sign, and publish packages and docker images automatically #1059

Merged
merged 33 commits into from
Feb 28, 2020
Merged

Build, sign, and publish packages and docker images automatically #1059

merged 33 commits into from
Feb 28, 2020

Conversation

leodido
Copy link
Member

@leodido leodido commented Feb 25, 2020 •
edited by fntlnz
Loading

Co-authored-by: Lorenzo Fontana [email protected]
Signed-off-by: Leonardo Di Donato [email protected]

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?
/area build

What this PR does / why we need it:

Adds steps to let @poiana publish the built packages to the public repositories. Note only packages from the master and git tags will be published.

This way it aims to remove the dependency from the sysdig S3 for hosting DEB, RPM, etc.

Also, this PR introduces a release workflow when there is a git tag on the current commit.

Furthermore, this PR lets the CI build and publish the Falco docker images (which have been simplified a bit and refactored to use the new public repositories).

Which issue(s) this PR fixes:

Fixes #1056
Fixes #1057
Fixes #1062
Fixes #1058
Fixes #1063
Fixes #726

Refs #1019
Refs #705

Special notes for your reviewer:

  • create the new open repositories
  • publish the gpg public key
    • sign
  • automate the publishing of packages
    • from master commits
    • from git tag
  • automate the publish of docker images
  • docs: updates regarding falco packages falco-website#153
  • publish packages for release 0.20.0 (so to be able to merge docs)
    • deb
    • rpm
    • tgz
    • empty the *-dev repositories manually
  • update docker images
    • stable
    • dev
    • local
    • minimal
    • slim-dev
    • slim-stable
    • remove *-dev images in favor of build arguments at build time
  • automatically push docker images
    • falcosecurity/falco:master
    • falcosecurity/falco:latest (git tag)
    • falcosecurity/falco:master-slim
    • falcosecurity/falco:latest-slim (git tag)
    • falcosecurity/falco:master-minimal
    • falcosecurity/falco:latest-minimal (git tag)

Does this PR introduce a user-facing change?:

new: automatically publish DEB packages (from git master branch) to public dev repository
new: automatically publish RPM packages (from git master branch) to public dev repository
new: automatically release DEB packages (from git tags) to public repository
new: automatically release RPM packages (from git tags) to public repository
update: docker images use packages from the new repositories
fix: download Falco packages which URL contains character to encode - eg, `+`
update: docker image downloads old deb dependencies (gcc-6, gcc-5, binutils-2.30) from a new open repository
new: automatically publish docker images from master (master, master-slim, master-minimal)
new: automatically publish docker images from git tag (TAG, TAG-slim, TAG-master, latest, latest-slim, latest-minimal)
update: creating *-dev docker images using build arguments at build time
new: sign packages with falcosecurity GPG key

@poiana poiana requested review from krisnova and mstemm February 25, 2020 16:16
@poiana poiana added the size/S label Feb 25, 2020
@leodido leodido force-pushed the new/circleci-bintray-publish-packages branch from 4661694 to 93b5afe Compare February 25, 2020 16:18
@leodido
Copy link
Member Author

leodido commented Feb 25, 2020

/cc @fntlnz

@poiana poiana requested a review from fntlnz February 25, 2020 16:19
@leodido leodido force-pushed the new/circleci-bintray-publish-packages branch from 93b5afe to 924fef5 Compare February 25, 2020 19:08
@leodido leodido changed the title new(.circleci): initial job to publish deb package Publish packages Feb 25, 2020
@leodido leodido changed the title Publish packages wip: Publish packages Feb 25, 2020
@leodido leodido force-pushed the new/circleci-bintray-publish-packages branch from d7b502d to dc3bb40 Compare February 26, 2020 15:16
@poiana poiana added size/L and removed size/M labels Feb 26, 2020
@leodido leodido force-pushed the new/circleci-bintray-publish-packages branch from 68a5a03 to 4a446d5 Compare February 26, 2020 16:13
@leodido
Copy link
Member Author

leodido commented Feb 26, 2020

/milestone 0.21.0

@poiana poiana added this to the 0.21.0 milestone Feb 26, 2020
@leodido leodido force-pushed the new/circleci-bintray-publish-packages branch from 0b0a2b3 to 8bab936 Compare February 26, 2020 16:32
@fntlnz fntlnz mentioned this pull request Feb 27, 2020
Closed
@fntlnz fntlnz self-assigned this Feb 27, 2020
@leodido leodido force-pushed the new/circleci-bintray-publish-packages branch from e333a2f to 598493b Compare February 27, 2020 14:18
@poiana poiana added size/XL and removed size/L labels Feb 27, 2020
fntlnz and others added 14 commits February 28, 2020 14:41
@fntlnz @leodido
update(docker/stable): use the new debian packages infrastructure
4ba4a88 
Co-Authored-By: Leonardo Di Donato <[email protected]>
Signed-off-by: Lorenzo Fontana <[email protected]>
@fntlnz @leodido
new(docker): update local to use our own repositories
dd490c5 
Co-Authored-By: Leonardo Di Donato <[email protected]>
Signed-off-by: Lorenzo Fontana <[email protected]>
@fntlnz @leodido
new(docker/dev): update local dockerfile to use our own repositories
980579b 
Co-Authored-By: Leonardo Di Donato <[email protected]>
Signed-off-by: Lorenzo Fontana <[email protected]>
@leodido @fntlnz
new(.circleci): build and publish docker images (skeleton)
a9d417c 
Signed-off-by: Leonardo Di Donato <[email protected]>
Co-authored-by: Lorenzo Fontana <[email protected]>
@leodido
update(.circleci): create version before uploading it
765c6ae 
Signed-off-by: Leonardo Di Donato <[email protected]>
@leodido
update(.circleci): split run steps for publishing artifacts
b8b87dd 
Signed-off-by: Leonardo Di Donato <[email protected]>
@leodido
fix(.circleci): bintray auth for version creation
a5ca00c 
Signed-off-by: Leonardo Di Donato <[email protected]>
@fntlnz @leodido
new(.circleci): sign rpm packages
e2cfbf8 
Co-Authored-By: Leonardo Di Donato <[email protected]>
Signed-off-by: Lorenzo Fontana <[email protected]>
@leodido @fntlnz
new(.circleci): rpm sign for release workflow too
63a2951 
Co-authored-by: Lorenzo Fontana <[email protected]>
Signed-off-by: Leonardo Di Donato <[email protected]>
@leodido @fntlnz
fix(.circleci): rpmsign needs enter for empty passphrases
0469904 
Co-authored-by: Lorenzo Fontana <[email protected]>
Signed-off-by: Leonardo Di Donato <[email protected]>
@leodido @fntlnz
fix(.circleci): expect script needs eof
9c1ba75 
Co-authored-by: Lorenzo Fontana <[email protected]>
Signed-off-by: Leonardo Di Donato <[email protected]>
@leodido @fntlnz
update(docker): reorganize docker images with build arguments
7a28015 
Using the VERSION_BUCKET build arguments at docker build time users can now choose from which Falco version to build them.

Co-authored-by: Lorenzo Fontana <[email protected]>
Signed-off-by: Leonardo Di Donato <[email protected]>
@leodido @fntlnz
new(.circleci): build and publish docker images
8e52b36 
Co-authored-by: Lorenzo Fontana <[email protected]>
Signed-off-by: Leonardo Di Donato <[email protected]>
@leodido @fntlnz
fix(.circleci): sign RPMs
4e5075c 
Co-authored-by: Lorenzo Fontana <[email protected]>
Signed-off-by: Leonardo Di Donato <[email protected]>
@leodido leodido force-pushed the new/circleci-bintray-publish-packages branch from df28098 to 4e5075c Compare February 28, 2020 13:41
@leodido @fntlnz
update(.circleci): build and publish from master
9ff7408 
Co-authored-by: Lorenzo Fontana <[email protected]>
Signed-off-by: Leonardo Di Donato <[email protected]>
@leodido leodido requested a review from fntlnz February 28, 2020 15:11
@poiana poiana added the lgtm label Feb 28, 2020
@poiana
Copy link
Contributor

poiana commented Feb 28, 2020

LGTM label has been added.

Git tree hash: e703fbb6401916c05b09d3b51b39f6a866006ec8

@leodido leodido changed the title wip: Publish packages Build, sign, and publish packages and docker images automatically Feb 28, 2020
krisnova
krisnova approved these changes Feb 28, 2020
View reviewed changes
Copy link
Contributor

@krisnova krisnova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closes #1019

@poiana
Copy link
Contributor

poiana commented Feb 28, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, kris-nova

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit e637b1e into master Feb 28, 2020
@poiana poiana deleted the new/circleci-bintray-publish-packages branch February 28, 2020 16:32
@leodido leodido mentioned this pull request Mar 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krisnova krisnova krisnova approved these changes

@fntlnz fntlnz fntlnz approved these changes

@mstemm mstemm Awaiting requested review from mstemm

Assignees

@fntlnz fntlnz

@krisnova krisnova

Labels
approved area/build dco-signoff: yes kind/feature lgtm release-note size/XXL
Projects
None yet
Milestone
0.21.0
4 participants
@leodido @poiana @fntlnz @krisnova