Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct linting issue in rules #2039

Closed
wants to merge 31 commits into from
Closed

Correct linting issue in rules #2039

wants to merge 31 commits into from

Conversation

stephanmiehe
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

What this PR does / why we need it: Fixes a linting issue in the rules yaml

Which issue(s) this PR fixes: None

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?: No

NONE

@poiana
Copy link
Contributor

poiana commented Jun 3, 2022

Welcome @stephanmiehe! It looks like this is your first PR to falcosecurity/falco 🎉

@poiana
Copy link
Contributor

poiana commented Jun 3, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stephanmiehe
To complete the pull request process, please assign mstemm after the PR has been reviewed.
You can assign the PR to them by writing /assign @mstemm in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana requested review from mfdii and mstemm June 3, 2022 17:11
@poiana poiana added the size/XS label Jun 3, 2022
@stephanmiehe
Update falco_rules.yaml
f66a2f6 
Signed-off-by: stephanmiehe <[email protected]>
@jasondellaluce
Copy link
Contributor

/ok-to-test

@jasondellaluce
Copy link
Contributor

Closing and reopening to trigger the CI

/close

@poiana poiana closed this Jun 6, 2022
@poiana
Copy link
Contributor

poiana commented Jun 6, 2022

@jasondellaluce: Closed this PR.

In response to this:

Closing and reopening to trigger the CI

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jasondellaluce
Copy link
Contributor

/reopen

@poiana poiana reopened this Jun 6, 2022
@poiana
Copy link
Contributor

poiana commented Jun 6, 2022

@jasondellaluce: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jasondellaluce
Copy link
Contributor

/milestone 0.33.0

@poiana poiana added this to the 0.33.0 milestone Jun 6, 2022
@jasondellaluce
Copy link
Contributor

@stephanmiehe thank you for this! Can you please rebase your branch to master? That should be enough to make the CI jobs succeed!

@poiana
Copy link
Contributor

poiana commented Jun 9, 2022

@stephanmiehe: Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

stephanmiehe and others added 26 commits June 9, 2022 10:15
@stephanmiehe
Merge branch 'patch-1' of https://github.com/stephanmiehe/falco into …
7d1c78d 
…patch-1
@stephanmiehe
Merge branch 'patch-1' of https://github.com/stephanmiehe/falco into …
ae58be6 
…patch-1

Signed-off-by: stephanmiehe <[email protected]>
@stephanmiehe
Merge branch 'patch-1' of https://github.com/stephanmiehe/falco into …
852ea96 
…patch-1
@FedeDP @stephanmiehe
new(docker,scripts): port all docker images to be multiarch ready.
72ad1e3 
They can be pushed with `docker buildx` for various architectures.

Moreover, updated falco-driver-loader to support multiple architectures.

Signed-off-by: Federico Di Pierro <[email protected]>
@FedeDP @stephanmiehe
update(build): updated circle ci to properly use docker buildx to b…
92a6fce 
…uild multiplatform images.

Signed-off-by: Federico Di Pierro <[email protected]>
@FedeDP @stephanmiehe
update(scripts): ported publish-deb and publish-rpm scripts to be mul…
d40f5b5 
…ti arch.

Signed-off-by: Federico Di Pierro <[email protected]>
@Andreagit97 @stephanmiehe
chore(k8s_audit_plugin): bump k8s_audit_plugin version
d8d17fc 
Signed-off-by: Andrea Terzolo <[email protected]>
@Andreagit97 @stephanmiehe
tests(k8s_audit_plugin): fix a k8s_audit_plugin test
1b6b815 
Signed-off-by: Andrea Terzolo <[email protected]>
@FedeDP @stephanmiehe
fix(build): try to use root user for cimg/base.
b0c51fb 
Moreover, fixed buildx usage.

Signed-off-by: Federico Di Pierro <[email protected]>
@FedeDP @stephanmiehe
update(build): avoid double build of docker images when pushing to aw…
3bfd222 
…s ecr.

Moreover, fixed subtle whitespace-bug in various buildx lines.

Signed-off-by: Federico Di Pierro <[email protected]>
@FedeDP @stephanmiehe
fix(build): use apt instead of apk when installing deps for aws ecr p…
edd0637 
…ublish.

Signed-off-by: Federico Di Pierro <[email protected]>
@odidev @stephanmiehe
ARM64 build
3531281 
Signed-off-by: odidev <[email protected]>
@odidev @stephanmiehe
ARM64 build
079b6d1 
Signed-off-by: odidev <[email protected]>
@leogr @stephanmiehe
fix(.circleci): correct command for build-arm64
8a453a8 
Signed-off-by: Leonardo Grasso <[email protected]>
@FedeDP @leogr @stephanmiehe
update(docker): updated falco-builder to fix multiarch support.
eec42e7 
Signed-off-by: Federico Di Pierro <[email protected]>

Co-authored-by: Leonardo Grasso <[email protected]>
@FedeDP @stephanmiehe
fix(build): fixed circleCI artifacts publish for arm64.
facabe5 
Signed-off-by: Federico Di Pierro <[email protected]>
@FedeDP @stephanmiehe
fix(build): removed leftover line in circleci config.
b7c33a3 
Signed-off-by: Federico Di Pierro <[email protected]>
@alacuku @stephanmiehe
chore(cmake): bump falco-security libs version to 075da069af359954122…
f94a0e0 
…ed7b8a9fc98bc7bcf3116

Signed-off-by: Aldo Lacuku <[email protected]>
@alacuku @stephanmiehe
chore(engine): bump falco engine version number to 13
fe4885c 
Signed-off-by: Aldo Lacuku <[email protected]>
@alacuku @stephanmiehe
fix(falco): compilation issues with new libs version
32b8d64 
Signed-off-by: Aldo Lacuku <[email protected]>
@alacuku @stephanmiehe
chore(falco): fix indentation
5dbea58 
Signed-off-by: Aldo Lacuku <[email protected]>
@FedeDP @stephanmiehe
fix(scripts): forcefully create packages dir for debian packages.
288e8a9 
Signed-off-by: Federico Di Pierro <[email protected]>
@FedeDP @stephanmiehe
fix(scripts): fixed publish-deb script with manual arch filter.
7932c64 
Signed-off-by: Federico Di Pierro <[email protected]>

Merge branch 'falcosecurity:master' into patch-1
@stephanmiehe
Merge branch 'patch-1' of https://github.com/stephanmiehe/falco into …
83283f0 
…patch-1
@stephanmiehe
Merge branch 'patch-1' of https://github.com/stephanmiehe/falco into …
5c0fee9 
…patch-1

Signed-off-by: Stephan Miehe <[email protected]>
@stephanmiehe
Merge branch 'patch-1' of https://github.com/stephanmiehe/falco into …
6e78847 
…patch-1
@poiana
Copy link
Contributor

poiana commented Jun 9, 2022

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stephanmiehe
Copy link
Contributor Author

Moved to #2055

@jasondellaluce jasondellaluce modified the milestones: 0.33.0, 0.32.1 Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfdii mfdii Awaiting requested review from mfdii

@mstemm mstemm Awaiting requested review from mstemm

Assignees
No one assigned
Labels
area/rules dco-signoff: no do-not-merge/contains-merge-commits kind/cleanup release-note-none size/XS
Projects
None yet
Milestone
0.32.1
Development

Successfully merging this pull request may close these issues.
8 participants
@stephanmiehe @poiana @jasondellaluce @FedeDP @Andreagit97 @odidev @leogr @alacuku